This is an archive of the discontinued LLVM Phabricator instance.

Differential D125594

[lldb/API] Turn SBCompileUnit::GetIndexForLineEntry into FindLineEntryIndex (NFC)
ClosedPublic

Authored by mib on May 13 2022, 4:50 PM.

Details

Reviewers
JDevlieghere
Commits
rG174cf2f74762: [lldb/API] Turn SBCompileUnit::GetIndexForLineEntry into FindLineEntryIndex…
Summary

This patch renames the SBCompileUnit::GetIndexForLineEntry api to be
an overload of SBCompileUnit::FindLineEntryIndex

Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>

Diff Detail

Event Timeline

mib created this revision.May 13 2022, 4:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 13 2022, 4:50 PM
Herald added a subscriber: arphaman. · View Herald Transcript
mib requested review of this revision.May 13 2022, 4:50 PM
Herald added a subscriber: lldb-commits. · View Herald TranscriptMay 13 2022, 4:50 PM
Harbormaster completed remote builds in B164417: Diff 429391.May 13 2022, 4:52 PM
JDevlieghere accepted this revision.May 13 2022, 6:14 PM

LGTM

This revision is now accepted and ready to land.May 13 2022, 6:14 PM
Closed by commit rG174cf2f74762: [lldb/API] Turn SBCompileUnit::GetIndexForLineEntry into FindLineEntryIndex… (authored by mib). · Explain WhyMay 13 2022, 6:33 PM
This revision was automatically updated to reflect the committed changes.
mib added a commit: rG174cf2f74762: [lldb/API] Turn SBCompileUnit::GetIndexForLineEntry into FindLineEntryIndex….

Revision Contents

PathSize
lldb/
bindings/
interface/
4 lines
include/
lldb/
API/
4 lines
source/
API/
4 lines
test/
API/
python_api/
compile_unit/
2 lines

Diff 429399

lldb/bindings/interface/SBCompileUnit.i

Show First 20 Lines • Show All 73 Lines • ▼ Show 20 Lines @param[in] line_entry
The SBLineEntry object for which we are looking for the index. The SBLineEntry object for which we are looking for the index.
@param[in] exact @param[in] exact
An optional boolean defaulting to false that ensures that the provided An optional boolean defaulting to false that ensures that the provided
line entry has a perfect match in the compile unit. line entry has a perfect match in the compile unit.
@return @return
The index of the user-provided line entry. UINT32_MAX if the line entry The index of the user-provided line entry. UINT32_MAX if the line entry
was not found in the compile unit.") GetIndexForLineEntry; was not found in the compile unit.") FindLineEntryIndex;
uint32_t uint32_t
GetIndexForLineEntry (lldb::SBLineEntry &line_entry, bool exact = false) const; FindLineEntryIndex (lldb::SBLineEntry &line_entry, bool exact = false) const;
uint32_t uint32_t
FindLineEntryIndex (uint32_t start_idx, FindLineEntryIndex (uint32_t start_idx,
uint32_t line, uint32_t line,
lldb::SBFileSpec *inline_file_spec) const; lldb::SBFileSpec *inline_file_spec) const;
uint32_t uint32_t
FindLineEntryIndex (uint32_t start_idx, FindLineEntryIndex (uint32_t start_idx,
▲ Show 20 Lines • Show All 62 Lines • Show Last 20 Lines

lldb/include/lldb/API/SBCompileUnit.h

Show All 28 Linespublic:
bool IsValid() const; bool IsValid() const;
lldb::SBFileSpec GetFileSpec() const; lldb::SBFileSpec GetFileSpec() const;
uint32_t GetNumLineEntries() const; uint32_t GetNumLineEntries() const;
lldb::SBLineEntry GetLineEntryAtIndex(uint32_t idx) const; lldb::SBLineEntry GetLineEntryAtIndex(uint32_t idx) const;
uint32_t GetIndexForLineEntry(lldb::SBLineEntry &line_entry, uint32_t FindLineEntryIndex(lldb::SBLineEntry &line_entry,
bool exact = false) const; bool exact = false) const;
uint32_t FindLineEntryIndex(uint32_t start_idx, uint32_t line, uint32_t FindLineEntryIndex(uint32_t start_idx, uint32_t line,
lldb::SBFileSpec *inline_file_spec) const; lldb::SBFileSpec *inline_file_spec) const;
uint32_t FindLineEntryIndex(uint32_t start_idx, uint32_t line, uint32_t FindLineEntryIndex(uint32_t start_idx, uint32_t line,
lldb::SBFileSpec *inline_file_spec, lldb::SBFileSpec *inline_file_spec,
bool exact) const; bool exact) const;
▲ Show 20 Lines • Show All 52 Lines • Show Last 20 Lines

lldb/source/API/SBCompileUnit.cpp

Show First 20 Lines • Show All 71 Lines • ▼ Show 20 Lines if (line_table) {
if (line_table->GetLineEntryAtIndex(idx, line_entry)) if (line_table->GetLineEntryAtIndex(idx, line_entry))
sb_line_entry.SetLineEntry(line_entry); sb_line_entry.SetLineEntry(line_entry);
} }
} }
return sb_line_entry; return sb_line_entry;
} }
uint32_t SBCompileUnit::GetIndexForLineEntry(lldb::SBLineEntry &line_entry, uint32_t SBCompileUnit::FindLineEntryIndex(lldb::SBLineEntry &line_entry,
bool exact) const { bool exact) const {
LLDB_INSTRUMENT_VA(this, line_entry, exact); LLDB_INSTRUMENT_VA(this, line_entry, exact);
if (!m_opaque_ptr || !line_entry.IsValid()) if (!m_opaque_ptr || !line_entry.IsValid())
return UINT32_MAX; return UINT32_MAX;
LineEntry found_line_entry; LineEntry found_line_entry;
return m_opaque_ptr->FindLineEntry(0, line_entry.GetLine(), return m_opaque_ptr->FindLineEntry(0, line_entry.GetLine(),
▲ Show 20 Lines • Show All 146 Lines • Show Last 20 Lines

lldb/test/API/python_api/compile_unit/TestCompileUnitAPI.py

Show All 31 Lines def test(self):
line_entry = frame0.GetLineEntry() line_entry = frame0.GetLineEntry()
sc_list = target.FindCompileUnits(line_entry.GetFileSpec()) sc_list = target.FindCompileUnits(line_entry.GetFileSpec())
self.assertGreater(sc_list.GetSize(), 0) self.assertGreater(sc_list.GetSize(), 0)
main_cu = sc_list.compile_units[0] main_cu = sc_list.compile_units[0]
self.assertTrue(main_cu.IsValid(), "Main executable CU is not valid") self.assertTrue(main_cu.IsValid(), "Main executable CU is not valid")
self.assertEqual(main_cu.GetIndexForLineEntry(line_entry, True), self.assertEqual(main_cu.FindLineEntryIndex(line_entry, True),
main_cu.FindLineEntryIndex(0, line_entry.GetLine(), main_cu.FindLineEntryIndex(0, line_entry.GetLine(),
line_entry.GetFileSpec(), True)) line_entry.GetFileSpec(), True))