Rename SHAVE toolchain to Myriad toolchain.
Run the Myriad linker whenever the vendor [sic] is Myriad.
Details
Diff Detail
Event Timeline
lib/Driver/ToolChains.cpp | ||
---|---|---|
3959–3960 | I wonder if it would be a good idea to add support for other suffixes like "le" to the findBiarchMultilibs or somewhere around there instead of hardcoding le/ here. It looks like gcc has a whole bunch more things listed as possible MULTILIB_DIRNAMES for various targets. But LLVM seems to implement all the generality only for MIPS. | |
lib/Driver/ToolChains.h | ||
940 | Why is this not "T.getArch() == llvm::Triple::shave"? | |
lib/Driver/Tools.cpp | ||
9773 | Isn't whether this is needed dependent upon c++ vs not-c++, rather than rtems vs not-rtems? |
Changes per review - but only a minimally correct change to finding the libraries. Using multilibs remains as a future task.
Also renamed SHAVE::Linker to Myriad::Linker.
lib/Driver/ToolChains.cpp | ||
---|---|---|
3929 | Perhaps report an error if passed a cpu that's not sparc* or shave, since right now it'll get in here, and then just do something bogus? | |
lib/Driver/Tools.cpp | ||
9754 | should probably be conditioned on being little endian. | |
9792 | as discussed, libg and libc are identical, so probably should use -lc here too for consistency. |
Use the same logic as Solaris::Solaris to die in the toolchain constructor if getArch() is unexpected.
Also don't hardcode -EL in linker.
Other than minor comments, lgtm.
lib/Driver/ToolChains.cpp | ||
---|---|---|
3937 | I think you want something like: | |
test/Driver/shave-toolchain.c | ||
3 | Maybe some more check lines on this command, to verify that getCompilerSupportDir and getBuiltinLinkDir are returning useful values. |
Why is this not "T.getArch() == llvm::Triple::shave"?