This is an archive of the discontinued LLVM Phabricator instance.

[gn build] Use llvm-ar when clang_base_path is specified
ClosedPublic

Authored by aeubanks on May 11 2022, 9:20 AM.

Details

Summary

This prevents warnings with use_thinlto like

bfd plugin: LLVM gold plugin has failed to create LTO module: Not an int attribute (Producer: 'LLVM15.0.0git' Reader: 'LLVM 13.0.1')

Diff Detail

Event Timeline

aeubanks created this revision.May 11 2022, 9:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 11 2022, 9:20 AM
aeubanks requested review of this revision.May 11 2022, 9:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 11 2022, 9:20 AM
thakis accepted this revision.May 11 2022, 10:15 AM

I'm guessing we have the same problem on mac, but fine to fix that once someone tries to build with LTO there.

Can you say "linux" or "non-mac non-win" or similar in the commit message? Else, lg.

(Maybe we only want this if && use_thinlto? But as-is is fine too.)

This revision is now accepted and ready to land.May 11 2022, 10:15 AM
This revision was landed with ongoing or failed builds.May 11 2022, 10:41 AM
This revision was automatically updated to reflect the committed changes.