This is an archive of the discontinued LLVM Phabricator instance.

Differential D125305

[update_llc_test_checks] Baseline test for --asm-show-inst
ClosedPublic

Authored by arichardson on May 10 2022, 4:33 AM.

Details

Reviewers
None
Commits
rGf421659286af: [update_llc_test_checks] Baseline test for --asm-show-inst
Summary

To avoid test churn when backends add/rename new instructions/registers,
it makes sense to scrub the exact MCInst/Reg number.

Diff Detail

Event Timeline

arichardson created this revision.May 10 2022, 4:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 10 2022, 4:33 AM
arichardson added a child revision: D125307: [update_llc_test_checks] Use FileCheck captures for MCInst/MCReg output.May 10 2022, 5:06 AM
arichardson published this revision for review.May 10 2022, 5:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 10 2022, 5:09 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B163670: Diff 428337.May 10 2022, 5:15 AM
arichardson updated this revision to Diff 428390.May 10 2022, 8:25 AM

Simplify test

Harbormaster completed remote builds in B163705: Diff 428390.May 10 2022, 9:03 AM
This revision was not accepted when it landed; it landed in state Needs Review.May 14 2022, 7:43 AM
This revision was landed with ongoing or failed builds.
Closed by commit rGf421659286af: [update_llc_test_checks] Baseline test for --asm-show-inst (authored by arichardson). · Explain Why
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rGf421659286af: [update_llc_test_checks] Baseline test for --asm-show-inst.

Revision Contents

PathSize
llvm/
test/
tools/
UpdateTestChecks/
update_llc_test_checks/
Inputs/
13 lines
54 lines
5 lines

Diff 429454

llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/asm-show-inst.ll

  • This file was added.
;; Check that we remove the exact MCInst number from --asm-verbose output
; RUN: llc < %s -mtriple=i686-unknown-unknown --asm-show-inst | FileCheck %s --check-prefix=VERBOSE
; RUN: llc < %s -mtriple=i686-unknown-unknown | FileCheck %s --check-prefix=CHECK
define i8 @add_i8(i8 %a) nounwind {
%add = add i8 %a, 2
ret i8 %add
}
define i32 @add_i32(i32 %a) nounwind {
%add = add i32 %a, 2
ret i32 %add
}

llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/asm-show-inst.ll.expected

  • This file was added.
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
;; Check that we remove the exact MCInst number from --asm-verbose output
; RUN: llc < %s -mtriple=i686-unknown-unknown --asm-show-inst | FileCheck %s --check-prefix=VERBOSE
; RUN: llc < %s -mtriple=i686-unknown-unknown | FileCheck %s --check-prefix=CHECK
define i8 @add_i8(i8 %a) nounwind {
; VERBOSE-LABEL: add_i8:
; VERBOSE: # %bb.0:
; VERBOSE-NEXT: movb {{[0-9]+}}(%esp), %al # <MCInst #1804 MOV8rm
; VERBOSE-NEXT: # <MCOperand Reg:2>
; VERBOSE-NEXT: # <MCOperand Reg:33>
; VERBOSE-NEXT: # <MCOperand Imm:1>
; VERBOSE-NEXT: # <MCOperand Reg:0>
; VERBOSE-NEXT: # <MCOperand Imm:4>
; VERBOSE-NEXT: # <MCOperand Reg:0>>
; VERBOSE-NEXT: addb $2, %al # <MCInst #400 ADD8i8
; VERBOSE-NEXT: # <MCOperand Imm:2>>
; VERBOSE-NEXT: retl # <MCInst #2560 RET32
; VERBOSE-NEXT: # <MCOperand Reg:2>>
;
; CHECK-LABEL: add_i8:
; CHECK: # %bb.0:
; CHECK-NEXT: movb {{[0-9]+}}(%esp), %al
; CHECK-NEXT: addb $2, %al
; CHECK-NEXT: retl
%add = add i8 %a, 2
ret i8 %add
}
define i32 @add_i32(i32 %a) nounwind {
; VERBOSE-LABEL: add_i32:
; VERBOSE: # %bb.0:
; VERBOSE-NEXT: movl {{[0-9]+}}(%esp), %eax # <MCInst #1768 MOV32rm
; VERBOSE-NEXT: # <MCOperand Reg:22>
; VERBOSE-NEXT: # <MCOperand Reg:33>
; VERBOSE-NEXT: # <MCOperand Imm:1>
; VERBOSE-NEXT: # <MCOperand Reg:0>
; VERBOSE-NEXT: # <MCOperand Imm:4>
; VERBOSE-NEXT: # <MCOperand Reg:0>>
; VERBOSE-NEXT: addl $2, %eax # <MCInst #387 ADD32ri8
; VERBOSE-NEXT: # <MCOperand Reg:22>
; VERBOSE-NEXT: # <MCOperand Reg:22>
; VERBOSE-NEXT: # <MCOperand Imm:2>>
; VERBOSE-NEXT: retl # <MCInst #2560 RET32
; VERBOSE-NEXT: # <MCOperand Reg:22>>
;
; CHECK-LABEL: add_i32:
; CHECK: # %bb.0:
; CHECK-NEXT: movl {{[0-9]+}}(%esp), %eax
; CHECK-NEXT: addl $2, %eax
; CHECK-NEXT: retl
%add = add i32 %a, 2
ret i32 %add
}

llvm/test/tools/UpdateTestChecks/update_llc_test_checks/asm-show-inst.test

  • This file was added.
# REQUIRES: x86-registered-target
## Check that we insert regexes for MCInst/MCReg operands instead of hardcoding the numbers
# RUN: cp -f %S/Inputs/asm-show-inst.ll %t.ll && %update_llc_test_checks %t.ll
# RUN: diff -u %S/Inputs/asm-show-inst.ll.expected %t.ll