This is an archive of the discontinued LLVM Phabricator instance.

[Frontend] when attaching a preamble, don't generate the long predefines buffer.
ClosedPublic

Authored by sammccall on May 7 2022, 3:50 PM.

Details

Summary

We know we're going to overwrite it anyway.
It'd be a bit of work to coordinate not generating it at all, but setting this
flag avoids generating ~10k of the 13k string.

Diff Detail

Event Timeline

sammccall created this revision.May 7 2022, 3:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 7 2022, 3:50 PM
sammccall requested review of this revision.May 7 2022, 3:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 7 2022, 3:50 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
kadircet accepted this revision.May 9 2022, 5:54 AM
kadircet added inline comments.
clang/lib/Frontend/PrecompiledPreamble.cpp
769

s/The/Preamble

to almost nothing

This feels like too much of a detail, i'd probably drop. up to you though.

This revision is now accepted and ready to land.May 9 2022, 5:54 AM
This revision was landed with ongoing or failed builds.May 9 2022, 6:56 AM
This revision was automatically updated to reflect the committed changes.