[lldb] Add a function to check if lldb is running in an interactive session

[JDevlieghere]

Summary

This patch adds a function to check if lldb is running in an interactive debug session. Currently this API only works on macOS. It's expected to be used in combination with Host::OpenFileInExternalEditor.

[aprantl]

Thank you! This is equally useful and untestable :-)

[aprantl]

lldb/source/Host/macosx/objcxx/Host.mm

411

Wait. I think this is a misnomer. An lldb session over SSH is interactive, but not graphical. Should this be called IsInteractiveDesktopSession/IsInteractiveGraphicSession/IsInteractiveGUISession?

[JDevlieghere]

IsInteractiveSession -> IsInteractiveGraphicSession

[aprantl]

One last request: Could you add a Doxygen comment?

[mib]

lldb/source/Host/macosx/objcxx/Host.mm

411

FWIW, if you open a file on macOS over SSH, it would still open it in the default app. I'd expect the same behaviour here.

[mib]

lldb/source/Host/macosx/objcxx/Host.mm

411

FWIW, if you open a file on macOS over SSH, it would still open it in the default app. I'd expect the same behaviour here.

... Even if you're not in front of the screen.

[aprantl]

lldb/source/Host/macosx/objcxx/Host.mm

411

Right, that's why we don't want to open files in the external editor if we are connected over SSH.

lldb/include/lldb/Host/Host.h

static Status RunShellCommand(llvm::StringRef shell, const Args &args,
                                 int *signo_ptr, std::string *command_output,
                                 const Timeout<std::micro> &timeout,
                                 bool run_in_shell = true,
                                 bool hide_stderr = false);
 
   static bool OpenFileInExternalEditor(const FileSpec &file_spec,
                                        uint32_t line_no);
 
+  /// Check if we're running in an interactive graphical session.
+  ///
+  /// \return
+  ///     True if we're running in an interactive graphical session. False if
+  ///     we're not or don't know.
+  static bool IsInteractiveGraphicSession();
+
   static Environment GetEnvironment();
 
   static std::unique_ptr<Connection>
   CreateDefaultConnection(llvm::StringRef url);
 
 protected:
   static uint32_t FindProcessesImpl(const ProcessInstanceInfoMatch &match_info,
                                     ProcessInstanceInfoList &proc_infos);

lldb/source/Host/common/Host.cpp

 #endif
 
 #if !defined(__APPLE__)
 bool Host::OpenFileInExternalEditor(const FileSpec &file_spec,
                                     uint32_t line_no) {
   return false;
 }
 
+bool Host::IsInteractiveGraphicSession() { return false; }
 #endif
 
 std::unique_ptr<Connection> Host::CreateDefaultConnection(llvm::StringRef url) {
 #if defined(_WIN32)
   if (url.startswith("file://"))
     return std::unique_ptr<Connection>(new ConnectionGenericFile());
 #endif
   return std::unique_ptr<Connection>(new ConnectionFileDescriptor());

lldb/source/Host/macosx/objcxx/Host.mm

 #define LauncherXPCServicePosixspawnFlagsKey "posixspawnFlags"
 #define LauncherXPCServiceStdInPathKeyKey "stdInPath"
 #define LauncherXPCServiceStdOutPathKeyKey "stdOutPath"
 #define LauncherXPCServiceStdErrPathKeyKey "stdErrPath"
 #define LauncherXPCServiceChildPIDKey "childPID"
 #define LauncherXPCServiceErrorTypeKey "errorType"
 #define LauncherXPCServiceCodeTypeKey "errorCode"
 
+#include <bsm/audit.h>
+#include <bsm/audit_session.h>
 #endif
 
 #include "llvm/Support/Host.h"
 
 #include <asl.h>
 #include <crt_externs.h>
 #include <cstdio>
 #include <cstdlib>
if (error != noErr) {
 
     return false;
   }
 
   return true;
 #endif // TARGET_OS_OSX
 }
 
+bool Host::IsInteractiveGraphicSession() {
+#if !TARGET_OS_OSX
+  return false;
+#else
+  auditinfo_addr_t info;
+  getaudit_addr(&info, sizeof(info));
+  return info.ai_flags & AU_SESSION_FLAG_HAS_GRAPHIC_ACCESS;
+#endif
+}
+
 Environment Host::GetEnvironment() { return Environment(*_NSGetEnviron()); }
 
 static bool GetMacOSXProcessCPUType(ProcessInstanceInfo &process_info) {
   if (process_info.ProcessIDIsValid()) {
     // Make a new mib to stay thread safe
     int mib[CTL_MAXNAME] = {
         0,
     };