This is an archive of the discontinued LLVM Phabricator instance.

Differential D124838

tsan: fix deadlock in libbacktrace
ClosedPublic

Authored by marxin on May 3 2022, 3:45 AM.

Details

Reviewers
dvyukov
Commits
rG0a1bcab9f3bf: tsan: fix deadlock in libbacktrace
Summary

Fixes deadlock seen in GCC.

Fixes: #55226

Diff Detail

Event Timeline

marxin created this revision.May 3 2022, 3:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 3 2022, 3:45 AM
marxin requested review of this revision.May 3 2022, 3:45 AM
marxin updated this revision to Diff 426633.
marxin edited the summary of this revision. (Show Details)
dvyukov accepted this revision.May 3 2022, 3:48 AM
This revision is now accepted and ready to land.May 3 2022, 3:48 AM
This revision was landed with ongoing or failed builds.May 3 2022, 3:51 AM
Closed by commit rG0a1bcab9f3bf: tsan: fix deadlock in libbacktrace (authored by marxin). · Explain Why
This revision was automatically updated to reflect the committed changes.
marxin added a commit: rG0a1bcab9f3bf: tsan: fix deadlock in libbacktrace.
Herald added a project: Restricted Project. · View Herald TranscriptMay 3 2022, 3:51 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B162412: Diff 426633.May 3 2022, 4:03 AM

Revision Contents

PathSize
compiler-rt/
lib/
tsan/
rtl/
3 lines

Diff 426632

compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp

Show First 20 Lines • Show All 1,761 Lines • ▼ Show 20 LinesTSAN_INTERCEPTOR(int, listen, int fd, int backlog) {
int res = REAL(listen)(fd, backlog); int res = REAL(listen)(fd, backlog);
if (fd > 0 && res == 0) if (fd > 0 && res == 0)
FdAccess(thr, pc, fd); FdAccess(thr, pc, fd);
return res; return res;
} }
TSAN_INTERCEPTOR(int, close, int fd) { TSAN_INTERCEPTOR(int, close, int fd) {
SCOPED_INTERCEPTOR_RAW(close, fd); SCOPED_INTERCEPTOR_RAW(close, fd);
if (!in_symbolizer())
FdClose(thr, pc, fd); FdClose(thr, pc, fd);
return REAL(close)(fd); return REAL(close)(fd);
} }
#if SANITIZER_LINUX #if SANITIZER_LINUX
TSAN_INTERCEPTOR(int, __close, int fd) { TSAN_INTERCEPTOR(int, __close, int fd) {
SCOPED_INTERCEPTOR_RAW(__close, fd); SCOPED_INTERCEPTOR_RAW(__close, fd);
FdClose(thr, pc, fd); FdClose(thr, pc, fd);
return REAL(__close)(fd); return REAL(__close)(fd);
▲ Show 20 Lines • Show All 1,282 Lines • Show Last 20 Lines