[lldb] Use shutil.which in Shell tests find_executable

[DavidSpickett]

Summary

In build.py we have our own find_executable that looks
a lot like the distutils one that I switched to shutil.which.

This find_executable isn't quite the same as shutil.which
so I've refactored it to call that in the correct way.

Note that the path passed to shutil.which is in the form that
PATH would be, meaning separators are allowed.

>>> shutil.which("gcc", path="/home/david.spickett:/bin")
'/bin/gcc'

We just need to make sure it doesn't ignore the existing PATH
and normalise the result if it does find the binary.

The .exe extension is automatically added to the binary name
if we are on Windows.

Depends on D124601

[JDevlieghere]

LGTM

lldb/test/Shell/helper/build.py

 #!/usr/bin/env python
 
 from __future__ import print_function
 
 import argparse
 import os
+import shutil
 import signal
 import subprocess
 import sys
 
 if sys.platform == 'win32':
     # This module was renamed in Python 3.  Make sure to import it using a
     # consistent name regardless of python version.
     try:
if env is None:
         return
     for e in env:
         value = env[e]
         lines = value.split(os.pathsep)
         formatted_value = format_text(lines, 0, 7 + len(e))
         print('    {0} = {1}'.format(e, formatted_value))
 
 def find_executable(binary_name, search_paths):
-    if sys.platform == 'win32':
-        binary_name = binary_name + '.exe'
-
-    search_paths = os.pathsep.join(search_paths)
-    paths = search_paths + os.pathsep + os.environ.get('PATH', '')
-    for path in paths.split(os.pathsep):
-        p = os.path.join(path, binary_name)
-        if os.path.exists(p) and not os.path.isdir(p):
-            return os.path.normpath(p)
-    return None
+    # shutil.which will ignore PATH if given a path argument, we want to include it.
+    search_paths.append(os.environ.get('PATH', ''))
+    search_path = os.pathsep.join(search_paths)
+    binary_path = shutil.which(binary_name, path=search_path)
+    if binary_path is not None:
+        # So for example, we get '/bin/gcc' instead of '/usr/../bin/gcc'.
+        binary_path = os.path.normpath(binary_path)
+    return binary_path
 
 def find_toolchain(compiler, tools_dir):
     if compiler == 'msvc':
         return ('msvc', find_executable('cl', tools_dir))
     if compiler == 'clang-cl':
         return ('clang-cl', find_executable('clang-cl', tools_dir))
     if compiler == 'gcc':
         return ('gcc', find_executable('g++', tools_dir))