This is an archive of the discontinued LLVM Phabricator instance.

[OpaquePtr][GlobalOpt] Don't attempt to evaluate global constructors with arguments
ClosedPublic

Authored by aeubanks on Apr 27 2022, 1:48 PM.

Details

Summary

Previously all entries in global_ctors had to have the void()* type and
we'd skip evaluating bitcasted functions. With opaque pointers we may
see the function directly.

Fixes #55147.

Diff Detail

Event Timeline

aeubanks created this revision.Apr 27 2022, 1:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2022, 1:48 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
aeubanks requested review of this revision.Apr 27 2022, 1:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2022, 1:48 PM
aeubanks added a reviewer: Restricted Project.Apr 27 2022, 1:48 PM
nikic accepted this revision.Apr 27 2022, 2:13 PM
nikic added a subscriber: nikic.

LGTM

This revision is now accepted and ready to land.Apr 27 2022, 2:13 PM