This is an archive of the discontinued LLVM Phabricator instance.

Differential D124401

[flang] Accept "INFINITY" as real input
ClosedPublic

Authored by klausler on Apr 25 2022, 9:44 AM.

Details

Reviewers
vdonaldson
Commits
rGb8f5cf9d2c56: [flang] Accept "INFINITY" as real input
Summary

Both "INF" and "INFINITY" are standard.

Diff Detail

Event Timeline

klausler created this revision.Apr 25 2022, 9:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 25 2022, 9:44 AM
Herald added a subscriber: jdoerfert. · View Herald Transcript
klausler requested review of this revision.Apr 25 2022, 9:44 AM
vdonaldson accepted this revision.Apr 25 2022, 10:11 AM
This revision is now accepted and ready to land.Apr 25 2022, 10:11 AM
Harbormaster completed remote builds in B161195: Diff 424947.Apr 25 2022, 10:58 AM
Closed by commit rGb8f5cf9d2c56: [flang] Accept "INFINITY" as real input (authored by klausler). · Explain WhyApr 25 2022, 12:12 PM
This revision was automatically updated to reflect the committed changes.
klausler added a commit: rGb8f5cf9d2c56: [flang] Accept "INFINITY" as real input.

Revision Contents

PathSize
flang/
lib/
Decimal/
8 lines

Diff 424994

flang/lib/Decimal/decimal-to-binary.cpp

Show First 20 Lines • Show All 433 Lines • ▼ Show 20 Lines if ((!limit || limit >= p + 3) && toupper(p[0]) == 'N' &&
if (!limit || q < limit) { if (!limit || q < limit) {
isNegative_ = *q == '-'; isNegative_ = *q == '-';
if (isNegative_ || *q == '+') { if (isNegative_ || *q == '+') {
++q; ++q;
} }
} }
if ((!limit || limit >= q + 3) && toupper(q[0]) == 'I' && if ((!limit || limit >= q + 3) && toupper(q[0]) == 'I' &&
toupper(q[1]) == 'N' && toupper(q[2]) == 'F') { toupper(q[1]) == 'N' && toupper(q[2]) == 'F') {
if ((!limit || limit >= q + 8) && toupper(q[3]) == 'I' &&
toupper(q[4]) == 'N' && toupper(q[5]) == 'I' &&
toupper(q[6]) == 'T' && toupper(q[7]) == 'Y') {
p = q + 8;
} else {
p = q + 3; p = q + 3;
}
return {Real{Infinity()}}; return {Real{Infinity()}};
} else { } else {
// Invalid input // Invalid input
return {Real{NaN()}, Invalid}; return {Real{NaN()}, Invalid};
} }
} }
} }
} }
▲ Show 20 Lines • Show All 44 Lines • Show Last 20 Lines