This is an archive of the discontinued LLVM Phabricator instance.

[NFC][libc++][format] Enable unit tests.
ClosedPublic

Authored by Mordante on Apr 23 2022, 10:58 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rGd03bc249d81c: [NFC][libc++][format] Enable unit tests.
Summary

The GCC failures were partly fixed in D124103.

The format functions tests are fixed on GCC but they require a huge
amount of RAM (>10 GB). This fails with parallel testing in the CI. It
can be solved by splitting the test, but GCC-12 will be released shortly
and might fix the memory usage in these tests. Therefore these tests
remain disabled.

Diff Detail

Event Timeline

Mordante created this revision.Apr 23 2022, 10:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 23 2022, 10:58 AM
Mordante requested review of this revision.Apr 23 2022, 10:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 23 2022, 10:58 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Mordante updated this revision to Diff 425222.Apr 26 2022, 8:04 AM

Disable some tests for GCC, they fail due to extreme memory usage.

Mordante updated this revision to Diff 425238.Apr 26 2022, 8:55 AM

Disable Apple test since it still fails.

Mordante retitled this revision from [WIP] [NFC][libc++][format] Enable unit tests. to [NFC][libc++][format] Enable unit tests..Apr 26 2022, 9:03 AM
Mordante edited the summary of this revision. (Show Details)
Mordante updated this revision to Diff 425281.Apr 26 2022, 12:22 PM
Mordante edited the summary of this revision. (Show Details)

Rebased to see whether that fixes the CI.

ldionne accepted this revision.Apr 26 2022, 12:52 PM
ldionne added a subscriber: ldionne.

LGTM if CI is green.

This revision is now accepted and ready to land.Apr 26 2022, 12:52 PM
Mordante updated this revision to Diff 425699.Apr 27 2022, 11:16 PM

Rebase to test CI.

This revision was automatically updated to reflect the committed changes.