This is an archive of the discontinued LLVM Phabricator instance.

Differential D124210

Revert "[clang][safestack] Remove triple from stack usage test"
ClosedPublic

Authored by paulkirth on Apr 21 2022, 3:47 PM.

Details

Reviewers
None
Commits
rGb8786413d800: Revert "[clang][safestack] Remove triple from stack usage test"
Summary

This reverts commit 414f84ba29d96c8cbbe198cfc022146e4582cbef.

Requires deirectives had already been added to the test, and CC1 tests
should use a target triple.

Diff Detail

Event Timeline

paulkirth created this revision.Apr 21 2022, 3:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 21 2022, 3:47 PM
paulkirth requested review of this revision.Apr 21 2022, 3:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 21 2022, 3:47 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
This revision was not accepted when it landed; it landed in state Needs Review.Apr 21 2022, 3:48 PM
This revision was landed with ongoing or failed builds.
Closed by commit rGb8786413d800: Revert "[clang][safestack] Remove triple from stack usage test" (authored by paulkirth). · Explain Why
This revision was automatically updated to reflect the committed changes.
paulkirth added a commit: rGb8786413d800: Revert "[clang][safestack] Remove triple from stack usage test".
Harbormaster completed remote builds in B160739: Diff 424319.Apr 21 2022, 4:51 PM

Revision Contents

PathSize
clang/
test/
Frontend/
10 lines

Diff 424320

clang/test/Frontend/stack-usage-safestack.c

/// Check that stack frame size warnings behave the same when safe stack is enabled /// Check that stack frame size warnings behave the same when safe stack is enabled
// RUN: %clang_cc1 %s -fwarn-stack-size=48 -S -o - 2>&1 | FileCheck --check-prefix=REGULAR %s // REQUIRES: x86-registered-target
// RUN: %clang_cc1 %s -fwarn-stack-size=1060 -S -o - 2>&1 | FileCheck --check-prefix=IGNORE %s
// RUN: %clang_cc1 %s -fsanitize=safe-stack -fwarn-stack-size=48 -S -o - 2>&1 | FileCheck --check-prefix=SAFESTACK %s // RUN: %clang_cc1 %s -fwarn-stack-size=48 -S -o - -triple=i386-apple-darwin 2>&1 | FileCheck --check-prefix=REGULAR %s
// RUN: %clang_cc1 %s -fsanitize=safe-stack -fwarn-stack-size=1060 -S -o - 2>&1 | FileCheck --check-prefix=IGNORE %s // RUN: %clang_cc1 %s -fwarn-stack-size=1060 -S -o - -triple=i386-apple-darwin 2>&1 | FileCheck --check-prefix=IGNORE %s
// RUN: %clang_cc1 %s -fsanitize=safe-stack -fwarn-stack-size=48 -S -o - -triple=i386-apple-darwin 2>&1 | FileCheck --check-prefix=SAFESTACK %s
// RUN: %clang_cc1 %s -fsanitize=safe-stack -fwarn-stack-size=1060 -S -o - -triple=i386-apple-darwin 2>&1 | FileCheck --check-prefix=IGNORE %s
extern void init(char *buf, int size); extern void init(char *buf, int size);
extern int use_buf(char *buf, int size); extern int use_buf(char *buf, int size);
// REGULAR: warning: stack frame size ([[#]]) exceeds limit ([[#]]) in 'stackSizeWarning' // REGULAR: warning: stack frame size ([[#]]) exceeds limit ([[#]]) in 'stackSizeWarning'
// SAFESTACK: warning: stack frame size ([[#]]) exceeds limit ([[#]]) in 'stackSizeWarning' // SAFESTACK: warning: stack frame size ([[#]]) exceeds limit ([[#]]) in 'stackSizeWarning'
// IGNORE-NOT: stack frame size ([[#]]) exceeds limit ([[#]]) in 'stackSizeWarning' // IGNORE-NOT: stack frame size ([[#]]) exceeds limit ([[#]]) in 'stackSizeWarning'
void stackSizeWarning() { void stackSizeWarning() {
char buf[1024]; char buf[1024];
init(buf, sizeof(buf)); init(buf, sizeof(buf));
if (buf[0] < 42) if (buf[0] < 42)
use_buf(buf, sizeof(buf)); use_buf(buf, sizeof(buf));
} }