Make ProcessGDBRemote get a //copy// of platform Unix signals.

[chaoren]

Summary

Update to http://reviews.llvm.org/rL243618.

[tberghammer]

source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

853

I think it would be better to change SetUnixSignals to create the copy (or force the client side copy with some magic with rvalue references) because this error will happen almost every time somebody calls SetUnixSignals.

[labath]

source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

853

If the platform is supposed to hold signals, which are not to be changed by its users, I would have it hand out std::shared_ptr<CONST UnixSignals> (or even const UnixSignals & ?). Then the users will be forced to make a copy if they want to do anything to them.

[chaoren]

• Force client side copy.

[chaoren]

source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

853

If the platform is supposed to hold signals, which are not to be changed by its users

I think in my original discussion with Greg, we decided that it would be a good idea if we allow setting suppress/stop/notify for the platform signal set, and will be inherited by any process signal set created from it.

[chaoren]

• ProcessGDBRemote should automatically get a copy of GDBRemoteSignals.

[clayborg]

We do want processes to have individual copies that are copied from the platform. Does this actually make a copy? I don't see the copy.

[chaoren]

source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

2910

Here's the copy.

source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

ProcessGDBRemote::DoConnectRemote (Stream *strm, const char *remote_url)
 
     if (log)
         log->Printf ("ProcessGDBRemote::%s pid %" PRIu64 ": normalized target architecture triple: %s", __FUNCTION__, GetID (), GetTarget ().GetArchitecture ().GetTriple ().getTriple ().c_str ());
 
     if (error.Success())
     {
         PlatformSP platform_sp = GetTarget().GetPlatform();
         if (platform_sp && platform_sp->IsConnected())
-            SetUnixSignals(platform_sp->GetUnixSignals());
+            SetUnixSignals(std::make_shared<GDBRemoteSignals>(platform_sp->GetUnixSignals()));
         else
             SetUnixSignals(UnixSignals::Create(GetTarget().GetArchitecture()));
     }
 
     return error;
 }
 
 Error
// Scope the lock
         // Stopped state
         m_stop_packet_stack.push_back(response);
     }
 }
 
 //------------------------------------------------------------------
 // Process Queries
 //------------------------------------------------------------------
 
 bool
 ProcessGDBRemote::IsAlive ()
 {
     return m_gdb_comm.IsConnected() && m_private_state.GetValue() != eStateExited;
 }
 
 addr_t
 ProcessGDBRemote::GetImageInfoAddress()