This is an archive of the discontinued LLVM Phabricator instance.

Added worker and placeholder for standalone-build-x86_64 builder
ClosedPublic

Authored by kwk on Apr 21 2022, 7:13 AM.

Details

Summary

We plan on adding a Fedora based builder and worker that builds LLVM and some its subprojects in a standalone fashion. This just adds a regular builder and the worker. We do this because we want to test the connectivity of the infrastructure that we're setting up.

Diff Detail

Event Timeline

kwk created this revision.Apr 21 2022, 7:13 AM
Herald added a project: Restricted Project. · View Herald Transcript
kwk requested review of this revision.Apr 21 2022, 7:13 AM
kwk updated this revision to Diff 424198.Apr 21 2022, 7:18 AM
  • Added mail notifier for standalone-build-x86_64 builder
tstellar added inline comments.Apr 21 2022, 7:13 PM
buildbot/osuosl/master/config/builders.py
2364

So essentially this is just a place holder job to test out the new worker?

kwk added inline comments.Apr 21 2022, 11:14 PM
buildbot/osuosl/master/config/builders.py
2364

That is correct.

kwk retitled this revision from Added standalone-build-x86_64 builder to Added placeholder for standalone-build-x86_64 builder.Apr 21 2022, 11:15 PM
kwk edited the summary of this revision. (Show Details)
kwk retitled this revision from Added placeholder for standalone-build-x86_64 builder to Added worker and placeholder for standalone-build-x86_64 builder.
gkistanova added inline comments.Apr 23 2022, 12:27 AM
buildbot/osuosl/master/config/builders.py
2364

This will actually build and test, right?
If so, I'd remove the comment and consider this as a builder you are after at this point. Later it will change, and this is normal, many builders change over time.

kwk added inline comments.Apr 23 2022, 3:34 AM
buildbot/osuosl/master/config/builders.py
2364

Okay. Is the patch okay to merge otherwise? Can you approve it. I’m on the road and will remove the command and potentially merge it afterwards if you can approve.

kwk updated this revision to Diff 424714.Apr 23 2022, 4:47 AM
kwk edited the summary of this revision. (Show Details)
  • Remove comment on builder
kwk marked 2 inline comments as done.Apr 23 2022, 4:47 AM
kwk updated this revision to Diff 424715.Apr 23 2022, 4:55 AM
  • Rebased on main and removing fuzz
gkistanova accepted this revision.Apr 23 2022, 10:53 AM

Thanks, Konrad!

LGTM

This revision is now accepted and ready to land.Apr 23 2022, 10:53 AM