This is an archive of the discontinued LLVM Phabricator instance.

Differential D123904

[flang] Remove obsolete error check
AbandonedPublic

Authored by klausler on Apr 16 2022, 4:11 PM.

Details

Reviewers
vdonaldson
Summary

A check in intrinsic procedure call analysis is no longer needed
after some recent work in name resolution and is now emitting false
error messages; remove.

Diff Detail

Event Timeline

klausler created this revision.Apr 16 2022, 4:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 16 2022, 4:11 PM
Herald added a subscriber: jdoerfert. · View Herald Transcript
klausler requested review of this revision.Apr 16 2022, 4:11 PM
Harbormaster completed remote builds in B159954: Diff 423267.Apr 16 2022, 4:32 PM
klausler abandoned this revision.Apr 16 2022, 5:22 PM

Revision Contents

PathSize
flang/
lib/
Evaluate/
12 lines

Diff 423267

flang/lib/Evaluate/intrinsics.cpp

Context not available.
return specificCall; return specificCall;
} }
} }
if (IsIntrinsicFunction(call.name)) {
context.messages().Say(
"Cannot use intrinsic function '%s' as a subroutine"_err_en_US,
call.name);
}
return std::nullopt; // TODO return std::nullopt; // TODO
} }
Context not available.
} }
} }
if (specificBuffer.empty() && genericBuffer.empty() &&
IsIntrinsicSubroutine(call.name)) {
context.messages().Say(
"Cannot use intrinsic subroutine '%s' as a function"_err_en_US,
call.name);
}
// No match; report the right errors, if any // No match; report the right errors, if any
if (finalBuffer) { if (finalBuffer) {
if (specificBuffer.empty()) { if (specificBuffer.empty()) {
Context not available.