debugserver would never write modified xmm/ymm/zmm register values into the inferior

[jasonmolenda]

Summary

A small mistake in the method that accepts new xmm/ymm/zmm register values caused them to not be thread_set_state'd so the changes never took effect.

Update the three shell tests that test this functionality so they are xfail'ed with the system debugserver (which won't have this fix yet), but do pass with in-tree debugserver now on x86_64 darwin systems.

[JDevlieghere]

LGTM

lldb/test/Shell/Register/x86-64-write.test

-# XFAIL: system-darwin
+# xfail with system debugserver until the fix for
+# https://reviews.llvm.org/D123269 in
+# lldb/tools/debugserver/source/MacOSX/x86_64/DNBArchImplX86_64.cpp
+# has made it into released tools.
+# XFAIL: system-debugserver
+
 # XFAIL: system-windows
 # REQUIRES: native && target-x86_64
 # RUN: %clangxx_host %p/Inputs/x86-64-write.cpp -o %t
 # RUN: %lldb -b -s %s %t | FileCheck %s
 process launch
 
 register write r8 0x0001020304050607
 register write r9 0x1011121314151617

lldb/test/Shell/Register/x86-64-ymm-write.test

-# XFAIL: system-darwin
+# xfail with system debugserver until the fix for
+# https://reviews.llvm.org/D123269 in
+# lldb/tools/debugserver/source/MacOSX/x86_64/DNBArchImplX86_64.cpp
+# has made it into released tools.
+# XFAIL: system-debugserver
+
 # XFAIL: system-windows
 # REQUIRES: native && target-x86_64 && native-cpu-avx
 # RUN: %clangxx_host %p/Inputs/x86-ymm-write.cpp -o %t
 # RUN: %lldb -b -s %s %t | FileCheck %s
 process launch
 
 register write ymm0 "{0x00 0x01 0x02 0x03 0x04 0x05 0x06 0x07 0x08 0x09 0x0a 0x0b 0x0c 0x0d 0x0e 0x0f 0x10 0x11 0x12 0x13 0x14 0x15 0x16 0x17 0x18 0x19 0x1a 0x1b 0x1c 0x1d 0x1e 0x1f}"
 register write ymm1 "{0x01 0x02 0x03 0x04 0x05 0x06 0x07 0x08 0x09 0x0a 0x0b 0x0c 0x0d 0x0e 0x0f 0x10 0x11 0x12 0x13 0x14 0x15 0x16 0x17 0x18 0x19 0x1a 0x1b 0x1c 0x1d 0x1e 0x1f 0x20}"

lldb/test/Shell/Register/x86-64-zmm-write.test

-# XFAIL: system-darwin
+# xfail with system debugserver until the fix for
+# https://reviews.llvm.org/D123269 in
+# lldb/tools/debugserver/source/MacOSX/x86_64/DNBArchImplX86_64.cpp
+# has made it into released tools.
+# XFAIL: system-debugserver
+
 # XFAIL: system-freebsd
 # XFAIL: system-linux
 # XFAIL: system-netbsd
 # XFAIL: system-windows
 # REQUIRES: native && target-x86_64 && native-cpu-avx512f
 # RUN: %clangxx_host %p/Inputs/x86-zmm-write.cpp -o %t
 # RUN: %lldb -b -s %s %t | FileCheck %s
 process launch

lldb/tools/debugserver/source/MacOSX/x86_64/DNBArchImplX86_64.cpp

case e_regSetFPU:
       case fpu_ymm12:
       case fpu_ymm13:
       case fpu_ymm14:
       case fpu_ymm15:
         memcpy(&m_state.context.fpu.avx.__fpu_xmm0 + (reg - fpu_ymm0),
                &value->value.uint8, 16);
         memcpy(&m_state.context.fpu.avx.__fpu_ymmh0 + (reg - fpu_ymm0),
                (&value->value.uint8) + 16, 16);
-        return true;
+        success = true;
+        break;
       case fpu_k0:
       case fpu_k1:
       case fpu_k2:
       case fpu_k3:
       case fpu_k4:
       case fpu_k5:
       case fpu_k6:
       case fpu_k7:
         memcpy(&m_state.context.fpu.avx512f.__fpu_k0 + (reg - fpu_k0),
                &value->value.uint8, 8);
-        return true;
+        success = true;
+        break;
       case fpu_zmm0:
       case fpu_zmm1:
       case fpu_zmm2:
       case fpu_zmm3:
       case fpu_zmm4:
       case fpu_zmm5:
       case fpu_zmm6:
       case fpu_zmm7:
       case fpu_zmm8:
       case fpu_zmm9:
       case fpu_zmm10:
       case fpu_zmm11:
       case fpu_zmm12:
       case fpu_zmm13:
       case fpu_zmm14:
       case fpu_zmm15:
         memcpy(&m_state.context.fpu.avx512f.__fpu_xmm0 + (reg - fpu_zmm0),
                &value->value.uint8, 16);
         memcpy(&m_state.context.fpu.avx512f.__fpu_ymmh0 + (reg - fpu_zmm0),
                &value->value.uint8 + 16, 16);
         memcpy(&m_state.context.fpu.avx512f.__fpu_zmmh0 + (reg - fpu_zmm0),
                &value->value.uint8 + 32, 32);
-        return true;
+        success = true;
+        break;
       case fpu_zmm16:
       case fpu_zmm17:
       case fpu_zmm18:
       case fpu_zmm19:
       case fpu_zmm20:
       case fpu_zmm21:
       case fpu_zmm22:
       case fpu_zmm23:
       case fpu_zmm24:
       case fpu_zmm25:
       case fpu_zmm26:
       case fpu_zmm27:
       case fpu_zmm28:
       case fpu_zmm29:
       case fpu_zmm30:
       case fpu_zmm31:
         memcpy(&m_state.context.fpu.avx512f.__fpu_zmm16 + (reg - fpu_zmm16),
                &value->value.uint8, 64);
-        return true;
+        success = true;
+        break;
       }
       break;
 
     case e_regSetEXC:
       switch (reg) {
       case exc_trapno:
         m_state.context.exc.__trapno = value->value.uint32;
         success = true;