This is an archive of the discontinued LLVM Phabricator instance.

[clang] Verify internal entity module mangling
ClosedPublic

Authored by urnathan on Apr 6 2022, 7:29 AM.

Details

Summary

Internal symbol mangling is implementation-defined. We do not mangle any module attachment, and this adds a test to verify that.

Once GCC12 is released, I'll patch GCC to match this (for simplicity, as mentioned, it's not an ABI problem).

Diff Detail

Event Timeline

urnathan created this revision.Apr 6 2022, 7:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 6 2022, 7:29 AM
urnathan requested review of this revision.Apr 6 2022, 7:29 AM
dblaikie accepted this revision.Apr 6 2022, 1:31 PM

Sounds alright to me, though I'm not as familiar with the details - no doubt @iains can weigh in if there's anything extra/interesting, even if it's post-commit.

This revision is now accepted and ready to land.Apr 6 2022, 1:31 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 7 2022, 5:41 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript