Page MenuHomePhabricator

remove the "expand" diamond for variables where expanding fails
ClosedPublic

Authored by llunak on Apr 3 2022, 4:20 PM.

Details

Summary

If the variables view shows a variable that is a struct that has MightHaveChildren(), the expand diamond is shown, but if trying to expand it and it's not possible (e.g. incomplete type), remove the expand diamond to visualize that it can't be in fact expanded. Otherwise it feels kinda weird that a tree item cannot be expanded even though it "should".

I guess the MightHaveChildren() checking means that GetChildren() may be expensive, so also do not call it for rows that are not expanded.

Diff Detail

Event Timeline

llunak created this revision.Apr 3 2022, 4:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 3 2022, 4:20 PM
llunak requested review of this revision.Apr 3 2022, 4:20 PM
clayborg accepted this revision.Apr 7 2022, 8:57 AM
This revision is now accepted and ready to land.Apr 7 2022, 8:57 AM