This is an archive of the discontinued LLVM Phabricator instance.

Differential D122736

[libc++][ci] Installs Japanese locale in Docker.
ClosedPublic

Authored by Mordante on Mar 30 2022, 8:31 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG11c14bca58e6: [libc++][ci] Installs Japanese locale in Docker.
Summary

The alternative outputs of std::put_time and std::strftime are the
easiest to test with the Japanese locale. This is a preparation for the
tests of the chrono formatters.

Note since it takes a while before the Docker file changes propagate to
the build nodes the verification of the locale is done in a separate
patch.

Diff Detail

Event Timeline

Mordante created this revision.Mar 30 2022, 8:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2022, 8:31 AM
Herald added a subscriber: arichardson. · View Herald Transcript
Mordante requested review of this revision.Mar 30 2022, 8:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2022, 8:31 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Mordante mentioned this in D122738: [libc++][test] Use the Japanese locale..Mar 30 2022, 8:35 AM
Harbormaster completed remote builds in B156970: Diff 419159.Mar 30 2022, 10:18 AM
ldionne accepted this revision.Mar 30 2022, 3:15 PM
This revision is now accepted and ready to land.Mar 30 2022, 3:15 PM
Closed by commit rG11c14bca58e6: [libc++][ci] Installs Japanese locale in Docker. (authored by Mordante). · Explain WhyMar 31 2022, 8:41 AM
This revision was automatically updated to reflect the committed changes.
Mordante added a commit: rG11c14bca58e6: [libc++][ci] Installs Japanese locale in Docker..

Revision Contents

PathSize
libcxx/
utils/
ci/
3 lines

Diff 419483

libcxx/utils/ci/Dockerfile

Show All 40 Lines
RUN apt-get update && apt-get install -y bash curl RUN apt-get update && apt-get install -y bash curl
# Install various tools used by the build or the test suite # Install various tools used by the build or the test suite
RUN apt-get update && apt-get install -y ninja-build python3 python3-sphinx python3-distutils python3-psutil git gdb RUN apt-get update && apt-get install -y ninja-build python3 python3-sphinx python3-distutils python3-psutil git gdb
# Locales for gdb and localization tests # Locales for gdb and localization tests
RUN apt-get update && apt-get install -y language-pack-en language-pack-fr \ RUN apt-get update && apt-get install -y language-pack-en language-pack-fr \
language-pack-ru language-pack-zh-hans language-pack-ja language-pack-ru \
language-pack-zh-hans
# These two are not enabled by default so generate them # These two are not enabled by default so generate them
RUN printf "fr_CA ISO-8859-1\ncs_CZ ISO-8859-2" >> /etc/locale.gen RUN printf "fr_CA ISO-8859-1\ncs_CZ ISO-8859-2" >> /etc/locale.gen
RUN mkdir /usr/local/share/i1en/ RUN mkdir /usr/local/share/i1en/
RUN printf "fr_CA ISO-8859-1\ncs_CZ ISO-8859-2" >> /usr/local/share/i1en/SUPPORTED RUN printf "fr_CA ISO-8859-1\ncs_CZ ISO-8859-2" >> /usr/local/share/i1en/SUPPORTED
RUN locale-gen RUN locale-gen
# Install Clang <latest>, <latest-1> and ToT, which are the ones we support. # Install Clang <latest>, <latest-1> and ToT, which are the ones we support.
# We also install <latest-2> to allow smooth CI transitions around release points. # We also install <latest-2> to allow smooth CI transitions around release points.
▲ Show 20 Lines • Show All 49 Lines • Show Last 20 Lines