This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [doc] Update Windows build instructions after deprecating the legacy standalone builds
ClosedPublic

Authored by mstorsjo on Mar 30 2022, 3:39 AM.

Diff Detail

Event Timeline

mstorsjo created this revision.Mar 30 2022, 3:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2022, 3:39 AM
mstorsjo requested review of this revision.Mar 30 2022, 3:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2022, 3:39 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Mar 30 2022, 5:31 AM

This is great! However, do we even need to have special instructions for Windows? In an ideal world, we'd be able to share the same instructions for Windows and non-Windows. Until that can be achieved, fixing the Windows-specific documentation is the correct thing to do. Thanks!

This revision is now accepted and ready to land.Mar 30 2022, 5:31 AM

However, do we even need to have special instructions for Windows? In an ideal world, we'd be able to share the same instructions for Windows and non-Windows.

Ideally one wouldn't require special instructions, indeed. But there are a bunch of environmental details about how to set things up etc, so it's probably good to have concrete examples with commentery about things you need to consider.