This is an archive of the discontinued LLVM Phabricator instance.

Add new explanation for some shortcomings(WPD, CFI) for lexicon
ClosedPublic

Authored by lizhengxian.123 on Mar 25 2022, 3:45 AM.

Details

Summary

I add explanations for WPD(whole program devirtualization) and another meaning for CFI (control flow Integrity).

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2022, 3:45 AM
Herald added a subscriber: Prazek. · View Herald Transcript
lizhengxian.123 requested review of this revision.Mar 25 2022, 3:45 AM

Thanks for adding these. One suggestion/question below.

llvm/docs/Lexicon.rst
62

I can't find any other examples in this file of where an abbreviation has 2 possible definitions, so there doesn't seem to be any existing convention. I wonder if this case should look like:

**CFI**
Either:
Call Frame Information...

Or:
Control Flow Integrity...

or something similar, to make it clearer that there are 2 definitions being listed. wdyt?

Add more notes to tell people that CFI has two meanings.

Enna1 added a subscriber: Enna1.Mar 27 2022, 8:11 PM
MTC added a subscriber: MTC.Mar 27 2022, 8:21 PM
This revision is now accepted and ready to land.Mar 27 2022, 8:27 PM
MTC added inline comments.Mar 27 2022, 8:30 PM
llvm/docs/Lexicon.rst
332

Looks like you drop the newline at the end of file.

add a newline at the end of file.

This revision was landed with ongoing or failed builds.Mar 27 2022, 9:48 PM
This revision was automatically updated to reflect the committed changes.