build: tweak default builtins set for Darwin

[compnerd]

Summary

In light of the recent work to support building for the Darwin targets with
cmake, tweak the default builtins sources. Remove the apple versioning in
non-Apple builds, and remove the AEABI functions from the Apple build since it
does not conform to the AEABI RTABI.

[beanz]

LGTM. Sorry for losing track of this.

-Chris

[beanz]

(repeating feedback I just shared on IRC)

We actually need to do the aeabi filtering using the new Darwin-excludes filtering files I added this week. I'm currently working on replicating the functionality in the macho_embedded.mk makefile, which does need to include those sources, so we shouldn't just filter on if(APPLE).

If you list the aeabi functions in files named lib/builtins/Darwin-excludes/ios-armv7.txt and lib/builtins/Darwin-excludes/ios-armv7s.txt it should all work.

Let me know if there are any problems.

Thanks,
-Chris

[compnerd]

This was already done I believe and is no longer necessary.

lib/builtins/CMakeLists.txt

 # This directory contains a large amount of C code which provides
 # generic implementations of the core runtime library along with optimized
 # architecture-specific code in various subdirectories.
 
 set(GENERIC_SOURCES
   absvdi2.c
   absvsi2.c
   absvti2.c
   adddf3.c
   addsf3.c
   addtf3.c
   addvdi3.c
   addvsi3.c
   addvti3.c
-  apple_versioning.c
   ashldi3.c
   ashlti3.c
   ashrdi3.c
   ashrti3.c
   # FIXME: atomic.c may only be compiled if host compiler understands _Atomic
   # atomic.c
   clear_cache.c
   clzdi2.c
set(GENERIC_SOURCES
   udivmodsi4.c
   udivmodti4.c
   udivsi3.c
   udivti3.c
   umoddi3.c
   umodsi3.c
   umodti3.c)
 
+if (APPLE)
+  set(GENERIC_SOURCES
+      apple_versioning.c
+      ${GENERIC_SOURCES})
+endif ()
+
 if (HAVE_UNWIND_H)
   set(GENERIC_SOURCES
       ${GENERIC_SOURCES}
       gcc_personality_v0.c)
 endif ()
 
 set(x86_64_SOURCES
   x86_64/floatdidf.c

 endif()
 
 set(i686_SOURCES
   ${i386_SOURCES})
 
 set(arm_SOURCES
   arm/adddf3vfp.S
   arm/addsf3vfp.S
-  arm/aeabi_cdcmp.S
-  arm/aeabi_cdcmpeq_check_nan.c
-  arm/aeabi_cfcmp.S
-  arm/aeabi_cfcmpeq_check_nan.c
-  arm/aeabi_dcmp.S
-  arm/aeabi_div0.c
-  arm/aeabi_drsub.c
-  arm/aeabi_fcmp.S
-  arm/aeabi_frsub.c
-  arm/aeabi_idivmod.S
-  arm/aeabi_ldivmod.S
-  arm/aeabi_memcmp.S
-  arm/aeabi_memcpy.S
-  arm/aeabi_memmove.S
-  arm/aeabi_memset.S
-  arm/aeabi_uidivmod.S
-  arm/aeabi_uldivmod.S
   arm/bswapdi2.S
   arm/bswapsi2.S
   arm/comparesf2.S
   arm/divdf3vfp.S
   arm/divmodsi4.S
   arm/divsf3vfp.S
   arm/divsi3.S
   arm/eqdf2vfp.S
set(arm_SOURCES
   arm/truncdfsf2vfp.S
   arm/udivmodsi4.S
   arm/udivsi3.S
   arm/umodsi3.S
   arm/unorddf2vfp.S
   arm/unordsf2vfp.S
   ${GENERIC_SOURCES})
 
+if (NOT APPLE)
+  set(arm_SOURCES
+      arm/aeabi_cdcmp.S
+      arm/aeabi_cdcmpeq_check_nan.c
+      arm/aeabi_cfcmp.S
+      arm/aeabi_cfcmpeq_check_nan.c
+      arm/aeabi_dcmp.S
+      arm/aeabi_div0.c
+      arm/aeabi_drsub.c
+      arm/aeabi_fcmp.S
+      arm/aeabi_frsub.c
+      arm/aeabi_idivmod.S
+      arm/aeabi_ldivmod.S
+      arm/aeabi_memcmp.S
+      arm/aeabi_memcpy.S
+      arm/aeabi_memmove.S
+      arm/aeabi_memset.S
+      arm/aeabi_uidivmod.S
+      arm/aeabi_uldivmod.S
+      ${arm_SOURCES})
+endif ()
+
 set(aarch64_SOURCES
   comparetf2.c
   extenddftf2.c
   extendsftf2.c
   fixtfdi.c
   fixtfsi.c
   fixtfti.c
   fixunstfdi.c