Allow test suite run to be interupted using ctrl-C.

[EricWF]

Not sure what Arc is asking

[ldionne]

This sounds reasonable, but I'm curious -- can you describe what's the difference before and after the patch? Aren't we able to kill the test suite with CTRL-C right now?

[ldionne]

[Github PR transition cleanup]

Gentle ping on this, I still don't understand how this changes the current behavior. I thought it was possible to use Ctrl-C right now?

[EricWF]

So the difference before and after is that if we ctrl-C during a long running tests, and the test catches it, it effectively swallows it.

This only becomes an issue when we're at the end of the test suite or when only 1 or two tests are running, because otherwise there's a good chance that all the worker threads are running C++ code, and none of them are currently executing pyython which will propagate the error.

I think I would rather actually replace subprocess.call with os.execve and simply replace the python process with the subprocess. However IDK if that's going to play nice on all platforms we care about.
I'll close this and submit a github PR.

libcxx/utils/run.py

 
 It can perform code signing, forward arguments to the program, and return the
 program's error code.
 """
 
 import argparse
 import os
 import platform
+import signal
 import subprocess
 import sys
 
-
 def main():
     parser = argparse.ArgumentParser()
     parser.add_argument('--execdir', type=str, required=True)
     parser.add_argument('--codesign_identity', type=str, required=False, default=None)
     parser.add_argument('--env', type=str, nargs='*', required=False, default=dict())
     parser.add_argument("command", nargs=argparse.ONE_OR_MORE)
     args = parser.parse_args()
     commandLine = args.command
if platform.system() == 'Windows':
         # COMSPEC is needed for running subprocesses via std::system().
         if 'COMSPEC' in os.environ:
             env['COMSPEC'] = os.environ.get('COMSPEC')
         # TEMP is needed for placing temp files in a sensible directory.
         if 'TEMP' in os.environ:
             env['TEMP'] = os.environ.get('TEMP')
 
     # Run the command line with the given environment in the execution directory.
-    return subprocess.call(commandLine, cwd=args.execdir, env=env, shell=False)
-
+    exitCode = subprocess.call(commandLine, cwd=args.execdir, env=env, shell=False)
+    if exitCode == -signal.SIGINT:
+        raise KeyboardInterrupt
+    return exitCode
 
 if __name__ == '__main__':
     exit(main())