This is an archive of the discontinued LLVM Phabricator instance.

[lldb/crashlog] Create artificial frames for non-crashed scripted threads
ClosedPublic

Authored by mib on Mar 16 2022, 9:51 AM.

Details

Summary

This patch pipes down the -a|--load-all crashlog command option to the
Scripted Process initializer to load all the images used by crashed
process instead of only loading the images related to the crashed
thread.

This allows us to recreate artificial frames also for the non-crashed
scripted threads.

rdar://90396265

Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>

Diff Detail

Event Timeline

mib created this revision.Mar 16 2022, 9:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 16 2022, 9:51 AM
mib requested review of this revision.Mar 16 2022, 9:51 AM

Can we cover this case in the existing test?

mib added a comment.Mar 16 2022, 10:33 AM

Can we cover this case in the existing test?

We need to make it multi-threaded. I'll do it.

mib updated this revision to Diff 416001.Mar 16 2022, 3:18 PM

Add multithreaded crashlog test

mib updated this revision to Diff 416006.Mar 16 2022, 3:32 PM

Simplify test source checks

mib edited the summary of this revision. (Show Details)Mar 16 2022, 3:44 PM
JDevlieghere accepted this revision.Mar 16 2022, 3:49 PM

LGTM. I think we've reached a point where the test binary has become complex enough that we should check it in instead of hoping that the offsets will match, but that's something that can/should be done in a separate patch.

This revision is now accepted and ready to land.Mar 16 2022, 3:49 PM