This is an archive of the discontinued LLVM Phabricator instance.

[X86] Use the unaligned vector typedefs for the lddqu intrinsics pointer arguments (PR20670)
ClosedPublic

Authored by RKSimon on Mar 16 2022, 8:54 AM.

Details

Summary

Extension to rG4390c721cba09597037578100948bbc83cc41b16, similar to the vanilla load/store intrinsics, _mm_lddqu_si128/_mm256_lddqu_si256 should take an unaligned pointer, but were using the aligned m128i/m256i types which can cause alignment warnings.

The existing sse3-builtins.c and avx-builtins.c tests in llvm-project\clang\test\CodeGen\X86 should cover this.

Diff Detail

Event Timeline

RKSimon created this revision.Mar 16 2022, 8:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 16 2022, 8:54 AM
RKSimon requested review of this revision.Mar 16 2022, 8:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 16 2022, 8:54 AM
pengfei accepted this revision.Mar 16 2022, 6:11 PM

LGTM, thanks!

This revision is now accepted and ready to land.Mar 16 2022, 6:11 PM
This revision was landed with ongoing or failed builds.Mar 17 2022, 3:42 AM
This revision was automatically updated to reflect the committed changes.