This is an archive of the discontinued LLVM Phabricator instance.

[clang][deps] Simplify PREFIX definitions in tests
ClosedPublic

Authored by jansvoboda11 on Mar 12 2022, 3:39 AM.

Details

Summary

Instead of outputting the test directory into the JSON result file, parsing it with FileCheck and then potentially stripping it, simply use FileCheck's -D option.

Note that we use %/t instead of %t in order to normalize to forward slashes on Windows, which matches what we do with sed 's:\\\\\?:/:g'.

Diff Detail

Event Timeline

jansvoboda11 created this revision.Mar 12 2022, 3:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 12 2022, 3:39 AM
jansvoboda11 requested review of this revision.Mar 12 2022, 3:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 12 2022, 3:39 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
jansvoboda11 edited the summary of this revision. (Show Details)Mar 12 2022, 3:53 AM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 12 2022, 7:45 AM
This revision was automatically updated to reflect the committed changes.

In case you want to do a post-commit review.