This is an archive of the discontinued LLVM Phabricator instance.

Differential D121487

[lldb] Require native for command-thread-siginfo.test
ClosedPublic

Authored by asahay on Mar 11 2022, 12:20 PM.

Details

Reviewers
mgorny
ted
labath
Commits
rGd506a9ef2b32: [lldb] Require native for command-thread-siginfo.test
Summary

command-thread-siginfo.test employs a subject with a call to wait, and
thus requires system-linux. However, it's possible to target non-Linux
platforms despite operating on Linux hosts. So, have it require native
too.

Diff Detail

Event Timeline

asahay created this revision.Mar 11 2022, 12:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 11 2022, 12:20 PM
asahay requested review of this revision.Mar 11 2022, 12:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 11 2022, 12:20 PM
Herald added a subscriber: lldb-commits. · View Herald Transcript
Harbormaster completed remote builds in B153824: Diff 414728.Mar 11 2022, 12:23 PM
Herald added a subscriber: JDevlieghere. · View Herald TranscriptMar 11 2022, 12:23 PM
asahay added reviewers: mgorny, ted.Mar 11 2022, 12:30 PM
labath accepted this revision.Mar 14 2022, 1:13 AM
labath added a subscriber: labath.

Looks good, although I would be surprised if this was the only test which suffered from the same problem.

Another possibility would be to make the %clang_host substitution smarter and have it always build for the host, regardless of the value of llvm's default target triple.

This revision is now accepted and ready to land.Mar 14 2022, 1:13 AM
mgorny accepted this revision.Mar 14 2022, 6:21 AM

Thanks for catching this!

Closed by commit rGd506a9ef2b32: [lldb] Require native for command-thread-siginfo.test (authored by asahay). · Explain WhyMar 14 2022, 8:50 AM
This revision was automatically updated to reflect the committed changes.
asahay added a commit: rGd506a9ef2b32: [lldb] Require native for command-thread-siginfo.test.

Revision Contents

PathSize
lldb/
test/
Shell/
Commands/
2 lines

Diff 415105

lldb/test/Shell/Commands/command-thread-siginfo.test

# REQUIRES: system-linux # REQUIRES: native && system-linux
# RUN: %clang_host -g %S/Inputs/sigchld.c -o %t # RUN: %clang_host -g %S/Inputs/sigchld.c -o %t
# RUN: %lldb %t -b -s %s | FileCheck %s # RUN: %lldb %t -b -s %s | FileCheck %s
process launch -s process launch -s
process handle SIGCHLD -s true process handle SIGCHLD -s true
process continue process continue
# CHECK: signo = [[SIGNO:[0-9]+]] # CHECK: signo = [[SIGNO:[0-9]+]]
# CHECK: code = [[CODE:[0-9]+]] # CHECK: code = [[CODE:[0-9]+]]
Show All 10 Lines