This is an archive of the discontinued LLVM Phabricator instance.

[HIP] Fix -fno-gpu-sanitize
ClosedPublic

Authored by yaxunl on Mar 9 2022, 9:00 AM.

Details

Summary

Fix a typo about -fno-gpu-sanitize handling and disable warnings when
-fno-gpu-sanitize is specified.

Diff Detail

Event Timeline

yaxunl created this revision.Mar 9 2022, 9:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 9 2022, 9:00 AM
yaxunl requested review of this revision.Mar 9 2022, 9:00 AM
tra accepted this revision.Mar 9 2022, 10:26 AM
This revision is now accepted and ready to land.Mar 9 2022, 10:26 AM
This revision was landed with ongoing or failed builds.Mar 9 2022, 6:06 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 9 2022, 6:06 PM
MaskRay added inline comments.
clang/lib/Driver/ToolChains/HIPAMD.cpp
165

Note: the third argument of hasFlag defaults to true before I removed it in 522712e2d241ea33575a9c7a60ad582634f04f0d. I suspect it might not be what you intended.

yaxunl marked an inline comment as done.Mar 28 2022, 8:33 AM
yaxunl added inline comments.
clang/lib/Driver/ToolChains/HIPAMD.cpp
165

The default value of OPT_fgpu_sanitize is intended to be true. Thanks.