[libc++] Add tests for the content of <cstddef>

[ldionne]

Summary

As discussed in D114786.

[• Quuxplusone]

libcxx/test/libcxx/language.support/support.types/cstddef.compile.pass.cpp

19

The first was presumably a typo, but let's test both here, since otherwise we have no coverage for std::nullptr_t-in-C++03-mode.
Actually, you should probably just copy-paste the other test into this one and test all the things, e.g. ::max_align_t.

libcxx/test/std/language.support/support.types/cstddef.compile.pass.cpp

46

[ldionne]

Address review comments.

libcxx/test/libcxx/language.support/support.types/cstddef.compile.pass.cpp

19

Good catch.

[• Quuxplusone]

libcxx/test/std/language.support/support.types/cstddef.compile.pass.cpp

34

std::nullptr_t is also provided in C++03 mode, right? So this line (and maybe the other too) should go outside the #if, so they get tested in all modes.
(The only compiler+library combo that's ever tested in C++03 mode is clang+libc++, which does provide std::nullptr_t, so there's no reason to guard it under an #if.)

Otherwise we have no coverage for std::nullptr_t-in-C++03-mode.

[ldionne]

Address review comments.

libcxx/test/std/language.support/support.types/cstddef.compile.pass.cpp

34

Hmm, right. I'd still rather move that test to the libc++ specific test, just for clarity. But yeah, good catch again. I guess I don't care enough about C++03!

[ldionne]

All comments have been addressed, this should be fairly uncontroversial to land now. Can address post-commit if needed. Thanks for the review!

[• Quuxplusone]

LGTM

libcxx/test/libcxx/language.support/support.types/cstddef.compile.pass.cpp

+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// Make sure libc++'s <cstddef> defines types like ::nullptr_t in the global namespace.
+// This is a conforming extension to be consistent with other implementations, which all
+// appear to provide that behavior too.
+
+#include <cstddef>
+#include "test_macros.h"
+
+using PtrdiffT = ::ptrdiff_t;
+using SizeT = ::size_t;
+#if TEST_STD_VER >= 11
+using MaxAlignT = ::max_align_t;
+#endif
+
+// Supported in C++03 mode too for backwards compatibility with previous versions of libc++
+using NullptrT = ::nullptr_t;
+
+// Also ensure that we provide std::nullptr_t in C++03 mode, which is an extension too.
+using StdNullptrT = std::nullptr_t;

libcxx/test/std/language.support/support.types/cstddef.compile.pass.cpp

+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// test the contents of <cstddef>
+
+// namespace std {
+//   using ptrdiff_t = see below;
+//   using size_t = see below;
+//   using max_align_t = see below;
+//   using nullptr_t = decltype(nullptr);
+//
+//   enum class byte : unsigned char {};
+//
+//   // [support.types.byteops], byte type operations
+//      [...] other byte-related functionality is tested elsewhere
+// }
+//
+// #define NULL see below
+// #define offsetof(P, D) see below
+
+#include <cstddef>
+#include "test_macros.h"
+
+using PtrdiffT = std::ptrdiff_t;
+using SizeT = std::size_t;
+#if TEST_STD_VER >= 11
+using MaxAlignT = std::max_align_t;
+using NullptrT = std::nullptr_t;
+#endif
+
+#if TEST_STD_VER >= 17
+using Byte = std::byte;
+#endif
+
+#ifndef NULL
+#   error "NULL should be defined by <cstddef>"
+#endif
+
+#ifndef offsetof
+#   error "offsetof() should be defined by <cstddef>"
+#endif