This is an archive of the discontinued LLVM Phabricator instance.

Differential D120611

[libcxx] [test] Remove an incorrect XFAIL, fix CI on main
ClosedPublic

Authored by mstorsjo on Feb 25 2022, 11:23 PM.

Details

Reviewers
• Quuxplusone
stefanp
Group Reviewers
Restricted Project
Commits
rG1198c309db1a: [libcxx] [test] Remove an incorrect XFAIL, fix CI on main
Summary

9f5f08476e8979046ad3a13865d984c428eae442 / D119770 made this test
pass in the Windows configurations too, but didn't update the XFAIL
accordingly.

Diff Detail

Event Timeline

mstorsjo requested review of this revision.Feb 25 2022, 11:23 PM
mstorsjo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 25 2022, 11:23 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B151596: Diff 411582.Feb 26 2022, 12:22 AM
• Quuxplusone accepted this revision.Feb 26 2022, 8:25 AM

Sure, LGTM!

This revision is now accepted and ready to land.Feb 26 2022, 8:25 AM
Closed by commit rG1198c309db1a: [libcxx] [test] Remove an incorrect XFAIL, fix CI on main (authored by mstorsjo, committed by • arthur.j.odwyer). · Explain WhyFeb 26 2022, 9:30 AM
This revision was automatically updated to reflect the committed changes.
• arthur.j.odwyer added a commit: rG1198c309db1a: [libcxx] [test] Remove an incorrect XFAIL, fix CI on main.

Revision Contents

PathSize
libcxx/
test/
libcxx/
utilities/
format/
format.string/
format.string.std/
3 lines

Diff 411620

libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_string_unicode.pass.cpp

//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// UNSUPPORTED: c++03, c++11, c++14, c++17 // UNSUPPORTED: c++03, c++11, c++14, c++17
// UNSUPPORTED: libcpp-no-concepts // UNSUPPORTED: libcpp-no-concepts
// UNSUPPORTED: libcpp-has-no-incomplete-format // UNSUPPORTED: libcpp-has-no-incomplete-format
// UTF-32 doesn't work properly
// XFAIL: windows
// <format> // <format>
// Tests the Unicode width support of the standard format specifiers. // Tests the Unicode width support of the standard format specifiers.
// It tests [format.string.std]/8 - 11: // It tests [format.string.std]/8 - 11:
// - Properly determining the estimated with of a unicode string. // - Properly determining the estimated with of a unicode string.
// - Properly truncating to the wanted maximum width. // - Properly truncating to the wanted maximum width.
// This version runs the test when the platform has Unicode support. // This version runs the test when the platform has Unicode support.
▲ Show 20 Lines • Show All 250 Lines • Show Last 20 Lines