This is an archive of the discontinued LLVM Phabricator instance.

Differential D120577

[14.x] [clang] [test] Skip hip-fpie-option.hip if default-pie
ClosedPublic

Authored by mgorny on Feb 25 2022, 11:02 AM.

Details

Reviewers
MaskRay
Summary

Skip the hip-fpie-option.hip Driver test if default-pie-on-linux
is used. This test currently relies on default-no-pie, and it has been
changed to require default-pie in main.

Diff Detail

Event Timeline

mgorny created this revision.Feb 25 2022, 11:02 AM
Herald added a subscriber: yaxunl. · View Herald TranscriptFeb 25 2022, 11:02 AM
mgorny requested review of this revision.Feb 25 2022, 11:02 AM
Harbormaster completed remote builds in B151511: Diff 411463.Feb 25 2022, 11:02 AM
MaskRay accepted this revision.Feb 25 2022, 11:03 AM

Seems fine to push to release/14.x. Several Linux distros will use CLANG_DEFAULT_PIE_ON_LINUX=on and they might wonder why the test fails.

This revision is now accepted and ready to land.Feb 25 2022, 11:03 AM
MaskRay closed this revision.Feb 25 2022, 6:36 PM

mgorny pushed this to release/14.x

Revision Contents

PathSize
clang/
test/
Driver/
1 line

Diff 411463

clang/test/Driver/hip-fpie-option.hip

// REQUIRES: clang-driver, amdgpu-registered-target // REQUIRES: clang-driver, amdgpu-registered-target
// UNSUPPORTED: default-pie-on-linux
// -fPIC and -fPIE only affects host relocation model. // -fPIC and -fPIE only affects host relocation model.
// device compilation always uses PIC. // device compilation always uses PIC.
// RUN: %clang -### -target x86_64-unknown-linux-gnu \ // RUN: %clang -### -target x86_64-unknown-linux-gnu \
// RUN: --offload-arch=gfx906 %s -nogpulib -nogpuinc \ // RUN: --offload-arch=gfx906 %s -nogpulib -nogpuinc \
// RUN: 2>&1 | FileCheck -check-prefixes=DEV,HOST-STATIC %s // RUN: 2>&1 | FileCheck -check-prefixes=DEV,HOST-STATIC %s
Show All 30 Lines