This is an archive of the discontinued LLVM Phabricator instance.

Differential D120436

[libc++] Remove <chrono> include from <future>
ClosedPublic

Authored by philnik on Feb 23 2022, 2:07 PM.

Download Raw Diff

Details

Reviewers

• Quuxplusone

Group Reviewers

Restricted Project

Commits

rGde462a43d32a: [libc++] Remove <chrono> include from <future>

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

philnik requested review of this revision.Feb 23 2022, 2:07 PM

philnik created this revision.

Herald added a project: Restricted Project. · View Herald TranscriptFeb 23 2022, 2:07 PM

Herald added a reviewer: Restricted Project. · View Herald Transcript

Herald added a subscriber: libcxx-commits. · View Herald Transcript

Assuming CI is green, ship it! Thanks. :)

This revision is now accepted and ready to land.Feb 23 2022, 2:10 PM

Harbormaster completed remote builds in B151140: Diff 410938.Feb 23 2022, 2:12 PM

Fix Documentation

Rebase onto main to fix documentation

Harbormaster completed remote builds in B151149: Diff 410952.Feb 23 2022, 4:50 PM

Closed by commit rGde462a43d32a: [libc++] Remove <chrono> include from <future> (authored by philnik). · Explain WhyFeb 24 2022, 1:06 AM

This revision was automatically updated to reflect the committed changes.

philnik added a commit: rGde462a43d32a: [libc++] Remove <chrono> include from <future>.

Revision Contents

Path

Size

libcxx/

include/

2 lines

Diff 411029

libcxx/include/future

	Show First 20 Lines • Show All 371 Lines • ▼ Show 20 Lines
	#include <__utility/forward.h>			#include <__utility/forward.h>
	#include <exception>			#include <exception>
	#include <memory>			#include <memory>
	#include <mutex>			#include <mutex>
	#include <system_error>			#include <system_error>
	#include <thread>			#include <thread>
	#include <version>			#include <version>

	#include <chrono> // TODO: Remove unused header

	#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)			#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
	# pragma GCC system_header			# pragma GCC system_header
	#endif			#endif

	#ifdef _LIBCPP_HAS_NO_THREADS			#ifdef _LIBCPP_HAS_NO_THREADS
	#error <future> is not supported on this single threaded system			#error <future> is not supported on this single threaded system
	#else // !_LIBCPP_HAS_NO_THREADS			#else // !_LIBCPP_HAS_NO_THREADS

	▲ Show 20 Lines • Show All 2,049 Lines • Show Last 20 Lines