This is an archive of the discontinued LLVM Phabricator instance.

Differential D120408

clang-format.el: Make clang-format work in indirect buffers.
ClosedPublic

Authored by phst on Feb 23 2022, 6:07 AM.

Details

Reviewers
sammccall
Commits
rG2f906683ed14: clang-format.el: Make clang-format work in indirect buffers.
Summary

In an indirect buffer, buffer-file-name is nil, so check the base buffer
instead. This works fine in direct buffers where buffer-base-buffer returns
nil.

Diff Detail

Event Timeline

phst requested review of this revision.Feb 23 2022, 6:07 AM
phst created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 23 2022, 6:07 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
sammccall accepted this revision.Feb 23 2022, 6:35 AM

Makes sense, thanks!

This revision is now accepted and ready to land.Feb 23 2022, 6:35 AM
Harbormaster completed remote builds in B151041: Diff 410793.Feb 23 2022, 6:47 AM
phst added a comment.Feb 23 2022, 6:48 AM

Thanks for the review! I think you have to commit this (I don't have commit access).

This revision was landed with ongoing or failed builds.Feb 23 2022, 8:00 AM
Closed by commit rG2f906683ed14: clang-format.el: Make clang-format work in indirect buffers. (authored by phst, committed by sammccall). · Explain Why
This revision was automatically updated to reflect the committed changes.
sammccall added a commit: rG2f906683ed14: clang-format.el: Make clang-format work in indirect buffers..

Revision Contents

PathSize
clang/
tools/
clang-format/
2 lines

Diff 410832

clang/tools/clang-format/clang-format.el

Show First 20 Lines • Show All 141 Lines • ▼ Show 20 Linesuses the function `buffer-file-name'."
(if (use-region-p) (if (use-region-p)
(list (region-beginning) (region-end)) (list (region-beginning) (region-end))
(list (point) (point)))) (list (point) (point))))
(unless style (unless style
(setq style clang-format-style)) (setq style clang-format-style))
(unless assume-file-name (unless assume-file-name
(setq assume-file-name buffer-file-name)) (setq assume-file-name (buffer-file-name (buffer-base-buffer))))
(let ((file-start (clang-format--bufferpos-to-filepos start 'approximate (let ((file-start (clang-format--bufferpos-to-filepos start 'approximate
'utf-8-unix)) 'utf-8-unix))
(file-end (clang-format--bufferpos-to-filepos end 'approximate (file-end (clang-format--bufferpos-to-filepos end 'approximate
'utf-8-unix)) 'utf-8-unix))
(cursor (clang-format--bufferpos-to-filepos (point) 'exact 'utf-8-unix)) (cursor (clang-format--bufferpos-to-filepos (point) 'exact 'utf-8-unix))
(temp-buffer (generate-new-buffer " *clang-format-temp*")) (temp-buffer (generate-new-buffer " *clang-format-temp*"))
(temp-file (make-temp-file "clang-format")) (temp-file (make-temp-file "clang-format"))
▲ Show 20 Lines • Show All 62 Lines • Show Last 20 Lines