[libcxx] [test] Fix locale.time.get.byname get_date and get_date_wide on Windows

[mstorsjo]

Summary

Also apply the same fix on glibc. This takes the test one step closer
to passing on glibc, but it still fails on the zh_CN test (which
requires a more involved fix in libc++ itself).

[mstorsjo]

Rerun CI on a non-broken base revision.

[Mordante]

LGTM, the CI issue seems unrelated.

[ldionne]

libcxx/test/std/localization/locale.categories/category.time/locale.time.get.byname/get_date.pass.cpp

66

Why didn't the test fail on Glibc previously?

[mstorsjo]

libcxx/test/std/localization/locale.categories/category.time/locale.time.get.byname/get_date.pass.cpp

66

It previously failed on Glibc, but it still does - see the edited comment further up in the file. Previously it said:

// GLIBC Expects "10/06/2009" for fr_FR as opposed to "10.06.2009"
// GLIBC also fails on the zh_CN test.
// XFAIL: linux

Now I've edited it to say

// GLIBC fails on the zh_CN test.
// XFAIL: linux

(Fixing the zh_CN testcase on Glibc is a bigger issue, which requires fixes to the libc++ library implementation itself - I have a PoC of such a fix that I can send later.)

[ldionne]

Thanks for the explanation, LGTM.

libcxx/test/std/localization/locale.categories/category.time/locale.time.get.byname/get_date.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //
 // NetBSD does not support LC_TIME at the moment
 // XFAIL: netbsd
 
 // REQUIRES: locale.en_US.UTF-8
 // REQUIRES: locale.fr_FR.UTF-8
 // REQUIRES: locale.ru_RU.UTF-8
 // REQUIRES: locale.zh_CN.UTF-8
 
-// GLIBC Expects "10/06/2009" for fr_FR as opposed to "10.06.2009"
-// GLIBC also fails on the zh_CN test.
+// GLIBC fails on the zh_CN test.
 // XFAIL: linux
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
-
 // <locale>
 
 // class time_get_byname<charT, InputIterator>
 
 // iter_type
 // get_date(iter_type s, iter_type end, ios_base& str,
 //          ios_base::iostate& err, tm* t) const;
 
std::tm t;
         assert(i.base() == in+sizeof(in)/sizeof(in[0])-1);
         assert(t.tm_mon == 5);
         assert(t.tm_mday == 10);
         assert(t.tm_year == 109);
         assert(err == std::ios_base::eofbit);
     }
     {
         const my_facet f(LOCALE_fr_FR_UTF_8, 1);
+#if defined(_WIN32) || defined(TEST_HAS_GLIBC)
+        const char in[] = "10/06/2009";
+#else
         const char in[] = "10.06.2009";
+#endif
         err = std::ios_base::goodbit;
         t = std::tm();
         I i = f.get_date(I(in), I(in+sizeof(in)/sizeof(in[0])-1), ios, err, &t);
         assert(i.base() == in+sizeof(in)/sizeof(in[0])-1);
         assert(t.tm_mon == 5);
         assert(t.tm_mday == 10);
         assert(t.tm_year == 109);
         assert(err == std::ios_base::eofbit);

libcxx/test/std/localization/locale.categories/category.time/locale.time.get.byname/get_date_wide.pass.cpp

 
 // XFAIL: libcpp-has-no-wide-characters
 
 // REQUIRES: locale.en_US.UTF-8
 // REQUIRES: locale.fr_FR.UTF-8
 // REQUIRES: locale.ru_RU.UTF-8
 // REQUIRES: locale.zh_CN.UTF-8
 
-// GLIBC Expects "10/06/2009" for fr_FR as opposed to "10.06.2009"
-// GLIBC also fails on the zh_CN test.
+// GLIBC fails on the zh_CN test.
 // XFAIL: linux
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
-
 // <locale>
 
 // class time_get_byname<charT, InputIterator>
 
 // iter_type
 // get_date(iter_type s, iter_type end, ios_base& str,
 //          ios_base::iostate& err, tm* t) const;
 
std::tm t;
         assert(i.base() == in+sizeof(in)/sizeof(in[0])-1);
         assert(t.tm_mon == 5);
         assert(t.tm_mday == 10);
         assert(t.tm_year == 109);
         assert(err == std::ios_base::eofbit);
     }
     {
         const my_facet f(LOCALE_fr_FR_UTF_8, 1);
+#if defined(_WIN32) || defined(TEST_HAS_GLIBC)
+        const wchar_t in[] = L"10/06/2009";
+#else
         const wchar_t in[] = L"10.06.2009";
+#endif
         err = std::ios_base::goodbit;
         t = std::tm();
         I i = f.get_date(I(in), I(in+sizeof(in)/sizeof(in[0])-1), ios, err, &t);
         assert(i.base() == in+sizeof(in)/sizeof(in[0])-1);
         assert(t.tm_mon == 5);
         assert(t.tm_mday == 10);
         assert(t.tm_year == 109);
         assert(err == std::ios_base::eofbit);