This is an archive of the discontinued LLVM Phabricator instance.

Differential D119758

[libc] [Obvious] Fix.
ClosedPublic

Authored by rtenneti on Feb 14 2022, 11:54 AM.

Details

Reviewers
rtenneti
Commits
rG31eccf99ec6b: [libc] [Obvious] Fix.
Summary

Disable getenv_test.

Diff Detail

Event Timeline

rtenneti created this revision.Feb 14 2022, 11:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 14 2022, 11:54 AM
Herald added subscribers: libc-commits, ecnelises, tschuett, mgorny. · View Herald Transcript
rtenneti requested review of this revision.Feb 14 2022, 11:54 AM
rtenneti accepted this revision.Feb 14 2022, 11:55 AM
This revision is now accepted and ready to land.Feb 14 2022, 11:55 AM
This revision was landed with ongoing or failed builds.Feb 14 2022, 11:56 AM
Closed by commit rG31eccf99ec6b: [libc] [Obvious] Fix. (authored by rtenneti). · Explain Why
This revision was automatically updated to reflect the committed changes.
rtenneti added a commit: rG31eccf99ec6b: [libc] [Obvious] Fix..
Harbormaster completed remote builds in B149466: Diff 408541.Feb 14 2022, 12:09 PM

Revision Contents

PathSize
libc/
test/
loader/
linux/
25 lines

Diff 408542

libc/test/loader/linux/CMakeLists.txt

Show All 37 Linesadd_loader_test(
loader_no_args_test loader_no_args_test
SRC SRC
main_without_args.cpp main_without_args.cpp
DEPENDS DEPENDS
.loader_test .loader_test
libc.loader.linux.crt1 libc.loader.linux.crt1
) )
add_loader_test( # TODO: Disableing this test temporarily.
getenv_test # add_loader_test(
SRC # getenv_test
getenv_test.cpp # SRC
DEPENDS # getenv_test.cpp
.loader_test # DEPENDS
libc.loader.linux.crt1 # .loader_test
libc.src.stdlib.getenv # libc.loader.linux.crt1
ENV # libc.src.stdlib.getenv
FRANCE=Paris # ENV
GERMANY=Berlin # FRANCE=Paris
) # GERMANY=Berlin
# )
# TODO: Disableing this test temporarily to investigate why gold fails to link # TODO: Disableing this test temporarily to investigate why gold fails to link
# and produce an executable for this test. Test works all fine with ld.bfd. # and produce an executable for this test. Test works all fine with ld.bfd.
#add_loader_test( #add_loader_test(
# loader_tls_test # loader_tls_test
# SRC # SRC
# tls_test.cpp # tls_test.cpp
Show All 9 Lines