This is an archive of the discontinued LLVM Phabricator instance.

Differential D11973

AVX512 : kadd implemantation
ClosedPublic

Authored by igorb on Aug 12 2015, 1:08 AM.

Details

Reviewers
AsafBadouh
delena
Commits
rG59ac33935721: AVX512: kadd implementation Added tests for encoding.
rL246432: AVX512: kadd implementation
Summary

AVX512: kadd implemantation
Added tests for encoding.

Diff Detail

Repository
rL LLVM

Event Timeline

igorb updated this revision to Diff 31906.Aug 12 2015, 1:08 AM
igorb retitled this revision from to AVX512 : kadd implemantation.
igorb updated this object.
igorb added reviewers: delena, AsafBadouh.
igorb set the repository for this revision to rL LLVM.
igorb added a subscriber: llvm-commits.
delena edited edge metadata.Aug 31 2015, 3:52 AM

LGTM

Closed by commit rL246432: AVX512: kadd implementation (authored by ibreger). · Explain WhyAug 31 2015, 4:51 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
lib/
Target/
X86/
6 lines
test/
MC/
X86/
8 lines
16 lines

Diff 33571

llvm/trunk/lib/Target/X86/X86InstrAVX512.td

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 1,949 Lines • ▼ Show 20 Linesmulticlass avx512_mask_binop<bits<8> opc, string OpcodeStr,
let Predicates = [prd], isCommutable = IsCommutable in let Predicates = [prd], isCommutable = IsCommutable in
def rr : I<opc, MRMSrcReg, (outs KRC:$dst), (ins KRC:$src1, KRC:$src2), def rr : I<opc, MRMSrcReg, (outs KRC:$dst), (ins KRC:$src1, KRC:$src2),
!strconcat(OpcodeStr, !strconcat(OpcodeStr,
"\t{$src2, $src1, $dst|$dst, $src1, $src2}"), "\t{$src2, $src1, $dst|$dst, $src1, $src2}"),
[(set KRC:$dst, (OpNode KRC:$src1, KRC:$src2))]>; [(set KRC:$dst, (OpNode KRC:$src1, KRC:$src2))]>;
} }
multiclass avx512_mask_binop_all<bits<8> opc, string OpcodeStr, multiclass avx512_mask_binop_all<bits<8> opc, string OpcodeStr,
SDPatternOperator OpNode, bit IsCommutable> { SDPatternOperator OpNode, bit IsCommutable,
Predicate prdW = HasAVX512> {
defm B : avx512_mask_binop<opc, !strconcat(OpcodeStr, "b"), VK8, OpNode, defm B : avx512_mask_binop<opc, !strconcat(OpcodeStr, "b"), VK8, OpNode,
HasDQI, IsCommutable>, VEX_4V, VEX_L, PD; HasDQI, IsCommutable>, VEX_4V, VEX_L, PD;
defm W : avx512_mask_binop<opc, !strconcat(OpcodeStr, "w"), VK16, OpNode, defm W : avx512_mask_binop<opc, !strconcat(OpcodeStr, "w"), VK16, OpNode,
HasAVX512, IsCommutable>, VEX_4V, VEX_L, PS; prdW, IsCommutable>, VEX_4V, VEX_L, PS;
defm D : avx512_mask_binop<opc, !strconcat(OpcodeStr, "d"), VK32, OpNode, defm D : avx512_mask_binop<opc, !strconcat(OpcodeStr, "d"), VK32, OpNode,
HasBWI, IsCommutable>, VEX_4V, VEX_L, VEX_W, PD; HasBWI, IsCommutable>, VEX_4V, VEX_L, VEX_W, PD;
defm Q : avx512_mask_binop<opc, !strconcat(OpcodeStr, "q"), VK64, OpNode, defm Q : avx512_mask_binop<opc, !strconcat(OpcodeStr, "q"), VK64, OpNode,
HasBWI, IsCommutable>, VEX_4V, VEX_L, VEX_W, PS; HasBWI, IsCommutable>, VEX_4V, VEX_L, VEX_W, PS;
} }
def andn : PatFrag<(ops node:$i0, node:$i1), (and (not node:$i0), node:$i1)>; def andn : PatFrag<(ops node:$i0, node:$i1), (and (not node:$i0), node:$i1)>;
def xnor : PatFrag<(ops node:$i0, node:$i1), (not (xor node:$i0, node:$i1))>; def xnor : PatFrag<(ops node:$i0, node:$i1), (not (xor node:$i0, node:$i1))>;
defm KAND : avx512_mask_binop_all<0x41, "kand", and, 1>; defm KAND : avx512_mask_binop_all<0x41, "kand", and, 1>;
defm KOR : avx512_mask_binop_all<0x45, "kor", or, 1>; defm KOR : avx512_mask_binop_all<0x45, "kor", or, 1>;
defm KXNOR : avx512_mask_binop_all<0x46, "kxnor", xnor, 1>; defm KXNOR : avx512_mask_binop_all<0x46, "kxnor", xnor, 1>;
defm KXOR : avx512_mask_binop_all<0x47, "kxor", xor, 1>; defm KXOR : avx512_mask_binop_all<0x47, "kxor", xor, 1>;
defm KANDN : avx512_mask_binop_all<0x42, "kandn", andn, 0>; defm KANDN : avx512_mask_binop_all<0x42, "kandn", andn, 0>;
defm KADD : avx512_mask_binop_all<0x4A, "kadd", add, 1, HasDQI>;
multiclass avx512_mask_binop_int<string IntName, string InstName> { multiclass avx512_mask_binop_int<string IntName, string InstName> {
let Predicates = [HasAVX512] in let Predicates = [HasAVX512] in
def : Pat<(!cast<Intrinsic>("int_x86_avx512_"##IntName##"_w") def : Pat<(!cast<Intrinsic>("int_x86_avx512_"##IntName##"_w")
(i16 GR16:$src1), (i16 GR16:$src2)), (i16 GR16:$src1), (i16 GR16:$src2)),
(COPY_TO_REGCLASS (!cast<Instruction>(InstName##"Wrr") (COPY_TO_REGCLASS (!cast<Instruction>(InstName##"Wrr")
(v16i1 (COPY_TO_REGCLASS GR16:$src1, VK16)), (v16i1 (COPY_TO_REGCLASS GR16:$src1, VK16)),
(v16i1 (COPY_TO_REGCLASS GR16:$src2, VK16))), GR16)>; (v16i1 (COPY_TO_REGCLASS GR16:$src2, VK16))), GR16)>;
▲ Show 20 Lines • Show All 4,840 Lines • Show Last 20 Lines

llvm/trunk/test/MC/X86/x86-64-avx512bw.s

Show First 20 Lines • Show All 4,106 Lines • ▼ Show 20 Lines
// CHECK: vpunpckhwd -8192(%rdx), %zmm26, %zmm30 // CHECK: vpunpckhwd -8192(%rdx), %zmm26, %zmm30
// CHECK: encoding: [0x62,0x61,0x2d,0x40,0x69,0x72,0x80] // CHECK: encoding: [0x62,0x61,0x2d,0x40,0x69,0x72,0x80]
vpunpckhwd -8192(%rdx), %zmm26, %zmm30 vpunpckhwd -8192(%rdx), %zmm26, %zmm30
// CHECK: vpunpckhwd -8256(%rdx), %zmm26, %zmm30 // CHECK: vpunpckhwd -8256(%rdx), %zmm26, %zmm30
// CHECK: encoding: [0x62,0x61,0x2d,0x40,0x69,0xb2,0xc0,0xdf,0xff,0xff] // CHECK: encoding: [0x62,0x61,0x2d,0x40,0x69,0xb2,0xc0,0xdf,0xff,0xff]
vpunpckhwd -8256(%rdx), %zmm26, %zmm30 vpunpckhwd -8256(%rdx), %zmm26, %zmm30
// CHECK: kaddd %k6, %k6, %k2
// CHECK: encoding: [0xc4,0xe1,0xcd,0x4a,0xd6]
kaddd %k6, %k6, %k2
// CHECK: kaddq %k4, %k6, %k3
// CHECK: encoding: [0xc4,0xe1,0xcc,0x4a,0xdc]
kaddq %k4, %k6, %k3
// CHECK: vpalignr $171, %zmm17, %zmm26, %zmm22 // CHECK: vpalignr $171, %zmm17, %zmm26, %zmm22
// CHECK: encoding: [0x62,0xa3,0x2d,0x40,0x0f,0xf1,0xab] // CHECK: encoding: [0x62,0xa3,0x2d,0x40,0x0f,0xf1,0xab]
vpalignr $171, %zmm17, %zmm26, %zmm22 vpalignr $171, %zmm17, %zmm26, %zmm22
// CHECK: vpalignr $171, %zmm17, %zmm26, %zmm22 {%k3} // CHECK: vpalignr $171, %zmm17, %zmm26, %zmm22 {%k3}
// CHECK: encoding: [0x62,0xa3,0x2d,0x43,0x0f,0xf1,0xab] // CHECK: encoding: [0x62,0xa3,0x2d,0x43,0x0f,0xf1,0xab]
vpalignr $171, %zmm17, %zmm26, %zmm22 {%k3} vpalignr $171, %zmm17, %zmm26, %zmm22 {%k3}
Show All 32 Lines

llvm/trunk/test/MC/X86/x86-64-avx512dq.s

Show First 20 Lines • Show All 2,365 Lines • ▼ Show 20 Lines
// CHECK: vcvtuqq2ps %zmm21, %ymm18 {%k2} // CHECK: vcvtuqq2ps %zmm21, %ymm18 {%k2}
// CHECK: encoding: [0x62,0xa1,0xff,0x4a,0x7a,0xd5] // CHECK: encoding: [0x62,0xa1,0xff,0x4a,0x7a,0xd5]
vcvtuqq2ps %zmm21, %ymm18 {%k2} vcvtuqq2ps %zmm21, %ymm18 {%k2}
// CHECK: vcvtuqq2ps %zmm21, %ymm18 {%k2} {z} // CHECK: vcvtuqq2ps %zmm21, %ymm18 {%k2} {z}
// CHECK: encoding: [0x62,0xa1,0xff,0xca,0x7a,0xd5] // CHECK: encoding: [0x62,0xa1,0xff,0xca,0x7a,0xd5]
vcvtuqq2ps %zmm21, %ymm18 {%k2} {z} vcvtuqq2ps %zmm21, %ymm18 {%k2} {z}
// CHECK: kaddb %k7, %k4, %k5
// CHECK: encoding: [0xc5,0xdd,0x4a,0xef]
kaddb %k7, %k4, %k5
// CHECK: kaddb %k4, %k6, %k5
// CHECK: encoding: [0xc5,0xcd,0x4a,0xec]
kaddb %k4, %k6, %k5
// CHECK: kaddw %k4, %k3, %k2
// CHECK: encoding: [0xc5,0xe4,0x4a,0xd4]
kaddw %k4, %k3, %k2
// CHECK: kaddw %k6, %k6, %k2
// CHECK: encoding: [0xc5,0xcc,0x4a,0xd6]
kaddw %k6, %k6, %k2