This is an archive of the discontinued LLVM Phabricator instance.

Differential D119464

[libc][obvious] only include vector with malloc
ClosedPublic

Authored by michaelrj on Feb 10 2022, 11:17 AM.

Details

Reviewers
None
Commits
rG03731ed39300: [libc][obvious] only include vector with malloc
Summary

the vector class, due to being dynamically resized, needs malloc. This
fixes the build so that it only includes it when malloc should be
available.

Diff Detail

Event Timeline

michaelrj created this revision.Feb 10 2022, 11:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 10 2022, 11:17 AM
Herald added subscribers: libc-commits, ecnelises, tschuett and 2 others. · View Herald Transcript
michaelrj requested review of this revision.Feb 10 2022, 11:17 AM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 10 2022, 11:17 AM
This revision was landed with ongoing or failed builds.
Closed by commit rG03731ed39300: [libc][obvious] only include vector with malloc (authored by michaelrj). · Explain Why
This revision was automatically updated to reflect the committed changes.
michaelrj added a commit: rG03731ed39300: [libc][obvious] only include vector with malloc.
Harbormaster completed remote builds in B148799: Diff 407614.Feb 10 2022, 11:22 AM

Revision Contents

PathSize
libc/
src/
__support/
CPP/
16 lines
test/
utils/
CPP/
20 lines

Diff 407615

libc/src/__support/CPP/CMakeLists.txt

# TODO(michaelrj): separate the standalone_cpp library into individual targets. # TODO(michaelrj): separate the standalone_cpp library into individual targets.
add_header_library( add_header_library(
standalone_cpp standalone_cpp
HDRS HDRS
Array.h Array.h
ArrayRef.h ArrayRef.h
Bit.h Bit.h
Bitset.h Bitset.h
Functional.h Functional.h
Limits.h Limits.h
StringView.h StringView.h
TypeTraits.h TypeTraits.h
) )
if(LLVM_LIBC_INCLUDE_SCUDO OR NOT LLVM_LIBC_FULL_BUILD)
add_header_library( add_header_library(
vector vector
HDRS HDRS
vector.h vector.h
DEPENDS DEPENDS
libc.include.stdlib libc.include.stdlib
) )
endif()

libc/test/utils/CPP/CMakeLists.txt

Show All 34 Linesadd_libc_unittest(
SUITE SUITE
libc_cpp_utils_unittests libc_cpp_utils_unittests
SRCS SRCS
arrayref_test.cpp arrayref_test.cpp
DEPENDS DEPENDS
libc.src.__support.CPP.standalone_cpp libc.src.__support.CPP.standalone_cpp
) )
if(LLVM_LIBC_INCLUDE_SCUDO OR NOT LLVM_LIBC_FULL_BUILD)
add_libc_unittest( add_libc_unittest(
vector_test vector_test
SUITE SUITE
libc_cpp_utils_unittests libc_cpp_utils_unittests
SRCS SRCS
vector_test.cpp vector_test.cpp
DEPENDS DEPENDS
libc.src.__support.CPP.vector libc.src.__support.CPP.vector
) )
endif()