This is an archive of the discontinued LLVM Phabricator instance.

Differential D119242

[libc] undefined reference in LibcTest.cpp
ClosedPublic

Authored by gchatelet on Feb 8 2022, 6:55 AM.

Details

Reviewers
sivachandra
Commits
rGd2c595466207: [libc] undefined reference in LibcTest.cpp
Summary

GCC complains about undefined reference in LibcTest.cpp and indeed the wrong version of the template has been explicitly instanciated.
This is necessary to get llvm-libc compile with GCC.

Mentionning D119002 here for navigability.

Diff Detail

Event Timeline

gchatelet created this revision.Feb 8 2022, 6:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 8 2022, 6:55 AM
Herald added subscribers: libc-commits, ecnelises, tschuett. · View Herald Transcript
gchatelet requested review of this revision.Feb 8 2022, 6:55 AM
Harbormaster completed remote builds in B148239: Diff 406806.Feb 8 2022, 7:06 AM
sivachandra accepted this revision.Feb 9 2022, 9:48 AM
sivachandra added inline comments.
libc/utils/UnitTest/LibcTest.cpp
200

I think what is happening is this: We were instantiating the member functions which call these non-member internal functions. So, the member function instantiation triggered the instantiation of these non-member functions. My guess is that, your GCC is probably not going through the call graph and instantiating the internal functions. Hence you are running into the undefined reference problem. That said though, instantiating these internal functions is more appropriate. So, your change LGTM.

This revision is now accepted and ready to land.Feb 9 2022, 9:48 AM
Closed by commit rGd2c595466207: [libc] undefined reference in LibcTest.cpp (authored by gchatelet). · Explain WhyFeb 9 2022, 12:46 PM
This revision was automatically updated to reflect the committed changes.
gchatelet added a commit: rGd2c595466207: [libc] undefined reference in LibcTest.cpp.
gchatelet mentioned this in D119002: [libc] Fix compilation with gcc.Feb 10 2022, 1:34 AM

Revision Contents

PathSize
libc/
utils/
UnitTest/
97 lines

Diff 407254

libc/utils/UnitTest/LibcTest.cpp

Show First 20 Lines • Show All 189 Lines • ▼ Show 20 Lines if (TestCount > 0) {
if (TestFilter) { if (TestFilter) {
std::cout << "No matching test for " << TestFilter << '\n'; std::cout << "No matching test for " << TestFilter << '\n';
} }
} }
return FailCount > 0 || TestCount == 0 ? 1 : 0; return FailCount > 0 || TestCount == 0 ? 1 : 0;
} }
template bool Test::test<char, 0>(TestCondition Cond, char LHS, char RHS, namespace internal {
const char *LHSStr, const char *RHSStr,
template bool test<char>(RunContext *Ctx, TestCondition Cond, char LHS,
sivachandraUnsubmitted
Done
ReplyInline Actions

I think what is happening is this: We were instantiating the member functions which call these non-member internal functions. So, the member function instantiation triggered the instantiation of these non-member functions. My guess is that, your GCC is probably not going through the call graph and instantiating the internal functions. Hence you are running into the undefined reference problem. That said though, instantiating these internal functions is more appropriate. So, your change LGTM.

sivachandra: I think what is happening is this: We were instantiating the member functions which call these…
char RHS, const char *LHSStr, const char *RHSStr,
const char *File, unsigned long Line); const char *File, unsigned long Line);
template bool Test::test<short, 0>(TestCondition Cond, short LHS, short RHS, template bool test<short>(RunContext *Ctx, TestCondition Cond, short LHS,
const char *LHSStr, const char *RHSStr, short RHS, const char *LHSStr, const char *RHSStr,
const char *File, unsigned long Line); const char *File, unsigned long Line);
template bool Test::test<int, 0>(TestCondition Cond, int LHS, int RHS, template bool test<int>(RunContext *Ctx, TestCondition Cond, int LHS, int RHS,
const char *LHSStr, const char *RHSStr, const char *LHSStr, const char *RHSStr,
const char *File, unsigned long Line); const char *File, unsigned long Line);
template bool Test::test<long, 0>(TestCondition Cond, long LHS, long RHS, template bool test<long>(RunContext *Ctx, TestCondition Cond, long LHS,
const char *LHSStr, const char *RHSStr, long RHS, const char *LHSStr, const char *RHSStr,
const char *File, unsigned long Line); const char *File, unsigned long Line);
template bool Test::test<long long, 0>(TestCondition Cond, long long LHS, template bool test<long long>(RunContext *Ctx, TestCondition Cond,
long long RHS, const char *LHSStr, long long LHS, long long RHS, const char *LHSStr,
const char *RHSStr, const char *File, const char *RHSStr, const char *File,
unsigned long Line); unsigned long Line);
template bool Test::test<__int128_t, 0>(TestCondition Cond, __int128_t LHS, template bool test<__int128_t>(RunContext *Ctx, TestCondition Cond,
__int128_t RHS, const char *LHSStr, __int128_t LHS, __int128_t RHS,
const char *RHSStr, const char *File, const char *LHSStr, const char *RHSStr,
unsigned long Line); const char *File, unsigned long Line);
template bool Test::test<unsigned char, 0>(TestCondition Cond, template bool test<unsigned char>(RunContext *Ctx, TestCondition Cond,
unsigned char LHS, unsigned char RHS, unsigned char LHS, unsigned char RHS,
const char *LHSStr, const char *LHSStr, const char *RHSStr,
const char *RHSStr, const char *File, const char *File, unsigned long Line);
unsigned long Line);
template bool template bool test<unsigned short>(RunContext *Ctx, TestCondition Cond,
Test::test<unsigned short, 0>(TestCondition Cond, unsigned short LHS, unsigned short LHS, unsigned short RHS,
unsigned short RHS, const char *LHSStr, const char *LHSStr, const char *RHSStr,
const char *RHSStr, const char *File, const char *File, unsigned long Line);
unsigned long Line);
template bool Test::test<unsigned int, 0>(TestCondition Cond, unsigned int LHS, template bool test<unsigned int>(RunContext *Ctx, TestCondition Cond,
unsigned int RHS, const char *LHSStr, unsigned int LHS, unsigned int RHS,
const char *RHSStr, const char *File, const char *LHSStr, const char *RHSStr,
unsigned long Line); const char *File, unsigned long Line);
template bool Test::test<unsigned long, 0>(TestCondition Cond, template bool test<unsigned long>(RunContext *Ctx, TestCondition Cond,
unsigned long LHS, unsigned long RHS, unsigned long LHS, unsigned long RHS,
const char *LHSStr, const char *LHSStr, const char *RHSStr,
const char *RHSStr, const char *File, const char *File, unsigned long Line);
unsigned long Line);
template bool Test::test<bool, 0>(TestCondition Cond, bool LHS, bool RHS, template bool test<bool>(RunContext *Ctx, TestCondition Cond, bool LHS,
bool RHS, const char *LHSStr, const char *RHSStr,
const char *File, unsigned long Line);
template bool test<unsigned long long>(RunContext *Ctx, TestCondition Cond,
unsigned long long LHS,
unsigned long long RHS,
const char *LHSStr, const char *RHSStr, const char *LHSStr, const char *RHSStr,
const char *File, unsigned long Line); const char *File, unsigned long Line);
template bool template bool test<__uint128_t>(RunContext *Ctx, TestCondition Cond,
Test::test<unsigned long long, 0>(TestCondition Cond, unsigned long long LHS, __uint128_t LHS, __uint128_t RHS,
unsigned long long RHS, const char *LHSStr, const char *LHSStr, const char *RHSStr,
const char *RHSStr, const char *File, const char *File, unsigned long Line);
unsigned long Line);
template bool Test::test<__uint128_t, 0>(TestCondition Cond, __uint128_t LHS, } // namespace internal
__uint128_t RHS, const char *LHSStr,
const char *RHSStr, const char *File,
unsigned long Line);
bool Test::testStrEq(const char *LHS, const char *RHS, const char *LHSStr, bool Test::testStrEq(const char *LHS, const char *RHS, const char *LHSStr,
const char *RHSStr, const char *File, unsigned long Line) { const char *RHSStr, const char *File, unsigned long Line) {
return internal::test(Ctx, Cond_EQ, LHS ? std::string(LHS) : std::string(), return internal::test(Ctx, Cond_EQ, LHS ? std::string(LHS) : std::string(),
RHS ? std::string(RHS) : std::string(), LHSStr, RHSStr, RHS ? std::string(RHS) : std::string(), LHSStr, RHSStr,
File, Line); File, Line);
} }
▲ Show 20 Lines • Show All 107 Lines • Show Last 20 Lines