[lldb] Print message after loading 'crashlog' command

[kastiglione]

Summary

Previously, importing crashlog resulted in a message being printed. The
message was about other commands (those in heap.py), not crashlog. The
changes in D117237 made it so that the heap.py messages were printed only when
importing lldb.macosx.heap, not when importing lldb.macosx.crashlog. Some
users may see no output and think crashlog wasn't successfully loaded. This
ensures users see that crashlog is loaded.

rdar://88283132

[JDevlieghere]

We have (shell) tests that import the crashlog command. Can you add a check line to make sure the message gets printed?

[kastiglione]

Update createPythonInit.py

[kastiglione]

We have (shell) tests that import the crashlog command. Can you add a check line to make sure the message gets printed?

The message isn't printed for a Python import, only for an lldb command script import.

[JDevlieghere]

In D119155#3301826, @kastiglione wrote:

We have (shell) tests that import the crashlog command. Can you add a check line to make sure the message gets printed?

The message isn't printed for a Python import, only for an lldb command script import.

Both ScriptInterpreter/Python/Crashlog/text.test and ScriptInterpreter/Python/Crashlog/json.test are using command script import.

[kastiglione]

Update tests

[kastiglione]

remove changes to createPythonInit.py

[JDevlieghere]

LGTM

lldb/examples/python/crashlog.py

if __name__ == '__main__':
     SymbolicateCrashLogs(debugger, sys.argv[1:])
     lldb.SBDebugger.Destroy(debugger)
 
 def __lldb_init_module(debugger, internal_dict):
     debugger.HandleCommand(
         'command script add -c lldb.macosx.crashlog.Symbolicate crashlog')
     debugger.HandleCommand(
         'command script add -f lldb.macosx.crashlog.save_crashlog save_crashlog')
+    print('"crashlog" and "save_crashlog" commands have been installed, use '
+          'the "--help" options on these commands for detailed help.')

lldb/test/Shell/Heap/heap-cstr.test

 # REQUIRES: system-darwin
 # REQUIRES: python
 # RUN: %clang_host %p/Inputs/cstr.c -g -o %t
 # RUN: %lldb -b -s %s -f %t | FileCheck %s
 
 br set -p return
 command script import lldb.macosx.heap
 run
-cstr "patatino"
+cstr_refs "patatino"
+
+# CHECK: "cstr_refs", {{.*}} commands have been installed, use the "--help" options on these commands
 
 # CHECK: {{.*}}: malloc(    16) -> {{.*}}

lldb/test/Shell/ScriptInterpreter/Python/Crashlog/json.test

 # RUN: %clang_host -g %S/Inputs/test.c -o %t.out
 
 # RUN: cp %S/Inputs/a.out.ips %t.crash
 # RUN: %python %S/patch-crashlog.py --binary %t.out --crashlog %t.crash --offsets '{"main":20, "bar":9, "foo":16}' --json
 # RUN: %lldb %t.out -o 'command script import lldb.macosx.crashlog' -o 'crashlog %t.crash' 2>&1 | FileCheck %s
 
 # RUN: cp %S/Inputs/a.out.ips %t.nometadata.crash
 # RUN: %python %S/patch-crashlog.py --binary %t.out --crashlog %t.nometadata.crash --offsets '{"main":20, "bar":9, "foo":16}' --json --no-metadata
 # RUN: %lldb %t.out -o 'command script import lldb.macosx.crashlog' -o 'crashlog %t.nometadata.crash' 2>&1 | FileCheck %s
 
+# CHECK: "crashlog" {{.*}} commands have been installed, use the "--help" options on these commands
+
 # CHECK: Thread[0] Crashing Thread Name EXC_BAD_ACCESS (SIGSEGV) (KERN_INVALID_ADDRESS at 0x0000000000000000)
 # CHECK: [  0] {{.*}}out`foo + 16 at test.c
 # CHECK: [  1] {{.*}}out`bar + 8 at test.c
 # CHECK: [  2] {{.*}}out`main + 19 at test.c
 # CHECK: rbp = 0x00007ffeec22a530
 # CHECK: tmp2 = 0x0000000000000008
 # CHECK: invalid foo
 # CHECK: invalid bar

lldb/test/Shell/ScriptInterpreter/Python/Crashlog/no_threadState.test

 # RUN: %clang_host -g %S/Inputs/test.c -o %t.out
 
 # RUN: cp %S/Inputs/no_threadState.ips %t.crash
 # RUN: %python %S/patch-crashlog.py --binary %t.out --crashlog %t.crash --offsets '{"main":20, "bar":9, "foo":16}' --json
 # RUN: %lldb %t.out -o 'command script import lldb.macosx.crashlog' -o 'crashlog %t.crash' 2>&1 | FileCheck %s
 
+# CHECK: "crashlog" {{.*}} commands have been installed, use the "--help" options on these commands
+
 # CHECK: Thread[0] Crashing Thread Name EXC_BAD_ACCESS (SIGSEGV) (KERN_INVALID_ADDRESS at 0x0000000000000000)
 # CHECK: [  0] {{.*}}out`foo + 16 at test.c
 # CHECK: [  1] {{.*}}out`bar + 8 at test.c
 # CHECK: [  2] {{.*}}out`main + 19 at test.c
 # CHECK: No thread state (register information) available

lldb/test/Shell/ScriptInterpreter/Python/Crashlog/text.test

 # RUN: %clang_host -g %S/Inputs/test.c -o %t.out
 # RUN: cp %S/Inputs/a.out.crash %t.crash
 # RUN: %python %S/patch-crashlog.py --binary %t.out --crashlog %t.crash --offsets '{"main":20, "bar":9, "foo":16}'
 # RUN: %lldb %t.out -o 'command script import lldb.macosx.crashlog' -o 'crashlog %t.crash' 2>&1 | FileCheck %s
 
+# CHECK: "crashlog" {{.*}} commands have been installed, use the "--help" options on these commands
+
 # CHECK: Thread[0] EXC_BAD_ACCESS (SIGSEGV) (KERN_INVALID_ADDRESS at 0x0000000000000000)
 # CHECK: [  0] {{.*}}out`foo + 16 at test.c
 # CHECK: [  1] {{.*}}out`bar + 8 at test.c
 # CHECK: [  2] {{.*}}out`main + 19 at test.c
 # CHECK: rbp = 0x00007ffee42d8020