This is an archive of the discontinued LLVM Phabricator instance.

Differential D119124

Removing unnecessary condition
Needs ReviewPublic

Authored by harishch4 on Feb 7 2022, 3:18 AM.

Download Raw Diff

Details

Reviewers

Summary

Fix to https://github.com/llvm/llvm-project/issues/53545

Diff Detail

Event Timeline

harishch4 requested review of this revision.Feb 7 2022, 3:18 AM

harishch4 created this revision.

Herald added a project: Restricted Project. · View Herald TranscriptFeb 7 2022, 3:18 AM

Herald added a subscriber: cfe-commits. · View Herald Transcript

Harbormaster completed remote builds in B147917: Diff 406374.Feb 7 2022, 3:57 AM

harishch4 updated this revision to Diff 406412.Feb 7 2022, 5:49 AM

Harbormaster completed remote builds in B147943: Diff 406412.Feb 7 2022, 5:49 AM

Remove unnecessary condition
missed return

Harbormaster completed remote builds in B148156: Diff 406691.Feb 7 2022, 10:40 PM

Revision Contents

Path

Size

clang/

lib/

Frontend/

CompilerInstance.cpp

1 line

Diff 406412

clang/lib/Frontend/CompilerInstance.cpp

Context not available.
	Loc.FileName, Loc.Line, Loc.Column,			Loc.FileName, Loc.Line, Loc.Column,
	getFrontendOpts().CodeCompleteOpts,			getFrontendOpts().CodeCompleteOpts,
	llvm::outs()));			llvm::outs()));
				return;
	} else if (EnableCodeCompletion(getPreprocessor(), Loc.FileName,			} else if (EnableCodeCompletion(getPreprocessor(), Loc.FileName,
	Loc.Line, Loc.Column)) {			Loc.Line, Loc.Column)) {
	setCodeCompletionConsumer(nullptr);			setCodeCompletionConsumer(nullptr);
Context not available.