This is an archive of the discontinued LLVM Phabricator instance.

Differential D119124

Removing unnecessary condition
Needs ReviewPublic

Authored by harishch4 on Feb 7 2022, 3:18 AM.

Details

Reviewers
llvm-commits
Summary

Fix to https://github.com/llvm/llvm-project/issues/53545

Diff Detail

Event Timeline

harishch4 requested review of this revision.Feb 7 2022, 3:18 AM
harishch4 created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 7 2022, 3:18 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B147917: Diff 406374.Feb 7 2022, 3:57 AM
harishch4 updated this revision to Diff 406412.Feb 7 2022, 5:49 AM
Harbormaster completed remote builds in B147943: Diff 406412.Feb 7 2022, 5:49 AM
harishch4 updated this revision to Diff 406691.Feb 7 2022, 8:41 PM
  • Remove unnecessary condition
  • missed return
Harbormaster completed remote builds in B148156: Diff 406691.Feb 7 2022, 10:40 PM

Revision Contents

PathSize
clang/
lib/
Frontend/
3 lines

Diff 406691

clang/lib/Frontend/CompilerInstance.cpp

Show First 20 Lines • Show All 709 Lines • ▼ Show 20 Lines
void CompilerInstance::createCodeCompletionConsumer() { void CompilerInstance::createCodeCompletionConsumer() {
const ParsedSourceLocation &Loc = getFrontendOpts().CodeCompletionAt; const ParsedSourceLocation &Loc = getFrontendOpts().CodeCompletionAt;
if (!CompletionConsumer) { if (!CompletionConsumer) {
setCodeCompletionConsumer( setCodeCompletionConsumer(
createCodeCompletionConsumer(getPreprocessor(), createCodeCompletionConsumer(getPreprocessor(),
Loc.FileName, Loc.Line, Loc.Column, Loc.FileName, Loc.Line, Loc.Column,
getFrontendOpts().CodeCompleteOpts, getFrontendOpts().CodeCompleteOpts,
llvm::outs())); llvm::outs()));
if (!CompletionConsumer)
return; return;
} else if (EnableCodeCompletion(getPreprocessor(), Loc.FileName, } else if (EnableCodeCompletion(getPreprocessor(), Loc.FileName,
Loc.Line, Loc.Column)) { Loc.Line, Loc.Column)) {
setCodeCompletionConsumer(nullptr); setCodeCompletionConsumer(nullptr);
return; return;
} }
} }
void CompilerInstance::createFrontendTimer() { void CompilerInstance::createFrontendTimer() {
▲ Show 20 Lines • Show All 1,558 Lines • Show Last 20 Lines