This is an archive of the discontinued LLVM Phabricator instance.

[gn build] Set -fmsc-version=1920 on Windows
ClosedPublic

Authored by aeubanks on Feb 1 2022, 9:26 AM.

Details

Summary

Now that the minimum version version of MSVC required to build LLVM has
been bumped, we see

../../llvm/include\llvm/Support/Compiler.h(94,2): error: LLVM requires
at least VS 2019.
#error LLVM requires at least VS 2019.

e.g. http://45.33.8.238/win/53703/step_4.txt

1920 corresponds to the earliest version of VS 2019.

Diff Detail

Event Timeline

aeubanks requested review of this revision.Feb 1 2022, 9:26 AM
aeubanks created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2022, 9:26 AM

We should explicitly pass _some_ version, else this picks up something depending on the local system. We want this to be as machine-independent as possible. (Think eg of goma, it might different versions server side and client side.)

(ps: I think the actual error is due to that bot actually having msvc 2017 installed. I tried to update it on the bot but in the process I broke rsync and I've been pretty busy with other stuff this week. Due to that, that bot hasn't had updated builds in a few days.)

aeubanks retitled this revision from [gn build] Remove -fmsc-version=1916 to [gn build] Set -fmsc-version=1920 on Windows.Feb 3 2022, 9:07 AM
aeubanks edited the summary of this revision. (Show Details)
thakis accepted this revision.Feb 3 2022, 3:55 PM

Thanks!

This revision is now accepted and ready to land.Feb 3 2022, 3:55 PM
This revision was landed with ongoing or failed builds.Feb 3 2022, 3:56 PM
This revision was automatically updated to reflect the committed changes.