This is an archive of the discontinued LLVM Phabricator instance.

Differential D118554

[InstCombine] Add test reproducing PR51435 (NFC)
ClosedPublic

Authored by rickyz on Jan 29 2022, 9:13 PM.

Details

Reviewers
spatel
Commits
rG2d283528ba97: [InstCombine] Add test reproducing PR51435 (NFC)

Diff Detail

Event Timeline

rickyz requested review of this revision.Jan 29 2022, 9:13 PM
rickyz created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 29 2022, 9:13 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
rickyz mentioned this in D115113: [InstCombine] Do not combine atomic and non-atomic loads..Jan 29 2022, 9:14 PM
rickyz added a parent revision: D116086: [InstCombine] Use range for loops (NFC).Jan 29 2022, 9:15 PM
rickyz added a child revision: D115113: [InstCombine] Do not combine atomic and non-atomic loads..
Harbormaster completed remote builds in B146505: Diff 404334.Jan 29 2022, 10:38 PM
spatel accepted this revision.Jan 30 2022, 6:32 AM
This revision is now accepted and ready to land.Jan 30 2022, 6:32 AM
This revision was landed with ongoing or failed builds.Jan 30 2022, 7:07 AM
Closed by commit rG2d283528ba97: [InstCombine] Add test reproducing PR51435 (NFC) (authored by rickyz, committed by spatel). · Explain Why
This revision was automatically updated to reflect the committed changes.
spatel added a commit: rG2d283528ba97: [InstCombine] Add test reproducing PR51435 (NFC).

Revision Contents

PathSize
llvm/
test/
Transforms/
InstCombine/
25 lines

Diff 404378

llvm/test/Transforms/InstCombine/phi.ll

Show First 20 Lines • Show All 541 Lines • ▼ Show 20 Lines
bb2: ; preds = %bb1, %entry bb2: ; preds = %bb1, %entry
%cond = phi i1 [ true, %bb1 ], [ false, %entry ] ; <i1> [#uses=1] %cond = phi i1 [ true, %bb1 ], [ false, %entry ] ; <i1> [#uses=1]
%val = phi i32 [ %0, %bb1 ], [ 0, %entry ] ; <i32> [#uses=1] %val = phi i32 [ %0, %bb1 ], [ 0, %entry ] ; <i32> [#uses=1]
%res = select i1 %cond, i32 %val, i32 0 ; <i32> [#uses=1] %res = select i1 %cond, i32 %val, i32 0 ; <i32> [#uses=1]
ret i32 %res ret i32 %res
} }
; FIXME: Atomic and non-atomic loads should not be combined.
define i32 @PR51435(i32* %ptr, i32* %atomic_ptr, i1 %c) {
; CHECK-LABEL: @PR51435(
; CHECK: entry:
; CHECK-NEXT: br i1 %c, label %if, label %end
; CHECK: if:
; CHECK-NEXT: [[ATOMIC:%.*]] = load atomic i32, i32* %atomic_ptr acquire, align 4
; CHECK-NEXT: br label %end
; CHECK: end:
; CHECK-NEXT: [[COND_IN:%.*]] = phi i32* [ %ptr, %entry ], [ %atomic_ptr, %if ]
; CHECK-NEXT: [[COND:%.*]] = load i32, i32* [[COND_IN]], align 4
; CHECK-NEXT: ret i32 [[COND]]
entry:
%x = load i32, i32* %ptr, align 4
br i1 %c, label %if, label %end
if:
%y = load atomic i32, i32* %atomic_ptr acquire, align 4
br label %end
end:
%cond = phi i32 [ %x, %entry ], [ %y, %if ]
ret i32 %cond
}
define i1 @test18(i1 %cond) { define i1 @test18(i1 %cond) {
; CHECK-LABEL: @test18( ; CHECK-LABEL: @test18(
; CHECK-NEXT: br i1 [[COND:%.*]], label [[TRUE:%.*]], label [[FALSE:%.*]] ; CHECK-NEXT: br i1 [[COND:%.*]], label [[TRUE:%.*]], label [[FALSE:%.*]]
; CHECK: true: ; CHECK: true:
; CHECK-NEXT: br label [[RET:%.*]] ; CHECK-NEXT: br label [[RET:%.*]]
; CHECK: false: ; CHECK: false:
; CHECK-NEXT: br label [[RET]] ; CHECK-NEXT: br label [[RET]]
; CHECK: ret: ; CHECK: ret:
▲ Show 20 Lines • Show All 691 Lines • Show Last 20 Lines