Linking against the atomic library when building lldb-server for mips32.

[Andrzej]

Summary

The linking fails when building lldb-server for mips32 unless the atomic library is added explicitly. This is related to the recent issue reported for Android (link: https://code.google.com/p/android/issues/detail?id=182094) and the corresponding LLVM commit (link: http://reviews.llvm.org/rL244298#6ea97418). However, this commit doesn't seem to solve the issue for lldb-server. The attached patch fixes the problem. Please, could you advise whether there's a neater or more generic way to solve this?

Thanks!

[chaoren]

Hi, sorry about the bogus fix. I tested it in the wrong place, so I thought
it worked. If you don't mind, could you please abandon this patch and let
me upload a follow up to my fix? I would prefer if this is confined to
Android.cmake.

[Andrzej]

That's perfectly fine. Thanks!

[ovyalov]

If we're going to use lldb-server on mips (outside of Android) do we still need this CL?

[chaoren]

I think this bug is specific to the toolchain, so probably not.

tools/lldb-server/CMakeLists.txt

   llvm_config(lldb-server ${LLVM_LINK_COMPONENTS})
 
   target_link_libraries(lldb-server ${LLDB_SYSTEM_LIBS})
+
+  # The linking fails when building for MIPS unless the atomic library
+  # is added explicitly.
+  if( CMAKE_SYSTEM_PROCESSOR STREQUAL "mips")
+    target_link_libraries(lldb-server atomic)
+  endif()
+
 endif()
 
 set_target_properties(lldb-server PROPERTIES VERSION ${LLDB_VERSION})