This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Fix mismatches between _aligned_malloc and free() on Windows
ClosedPublic

Authored by mstorsjo on Jan 25 2022, 2:03 PM.

Details

Summary

This allows getting rid of one case of LIBCXX-WINDOWS-FIXME. The fixme
comment was inaccurate; these functions are provided these days, but the
test kept failing as it was using mismatched allocation and free
functions.

A similar issue was fixed earlier, in
6596778b46ba69517191e7397289228168064ff4. That test was fixed by
overriding the aligned operator new too, and returning a dummy fixed
allocation instead. As this test is libcxx specific, it can use the
internal std::__libcpp_aligned_free() instead, to match libcxx's
internal aligned operator new.

Diff Detail

Event Timeline

mstorsjo requested review of this revision.Jan 25 2022, 2:03 PM
mstorsjo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 25 2022, 2:04 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Jan 25 2022, 3:40 PM
This revision is now accepted and ready to land.Jan 25 2022, 3:40 PM