This is an archive of the discontinued LLVM Phabricator instance.

[libcxx][test] Portably test that `{w,}format_context` is a specialization of `basic_format_context`
ClosedPublic

Authored by CaseyCarter on Jan 18 2022, 2:22 PM.

Diff Detail

Event Timeline

CaseyCarter requested review of this revision.Jan 18 2022, 2:22 PM
CaseyCarter created this revision.
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptJan 18 2022, 2:22 PM
Quuxplusone added a subscriber: Quuxplusone.

Seems uncontroversial to me.

libcxx/test/std/utilities/format/format.formatter/format.context/types.compile.pass.cpp
110–122

Primarily just to rename the lowercase template parameter charT.

Address review

CaseyCarter marked an inline comment as done.Jan 18 2022, 5:16 PM
CaseyCarter added inline comments.
libcxx/test/std/utilities/format/format.formatter/format.context/types.compile.pass.cpp
110–122

I when with CharT to be consistent with the rest of the file (which I should have done in the first place, instead of using charT to be consistent with the working draft).

Mordante accepted this revision.Jan 19 2022, 9:21 AM
Mordante added a subscriber: Mordante.

Thanks for the fix. LGTM!

libcxx/test/std/utilities/format/format.formatter/format.context/types.compile.pass.cpp
110–122

I too prefer CharT since that's consistent with the other <format> tests.

This revision is now accepted and ready to land.Jan 19 2022, 9:21 AM