Details
Details
- Reviewers
• Quuxplusone Mordante - Group Reviewers
Restricted Project - Commits
- rG3a1b178a0b8b: [libcxx][test] Portably test that `{w,}format_context` is a specialization of…
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Seems uncontroversial to me.
libcxx/test/std/utilities/format/format.formatter/format.context/types.compile.pass.cpp | ||
---|---|---|
110–122 | Primarily just to rename the lowercase template parameter charT. |
libcxx/test/std/utilities/format/format.formatter/format.context/types.compile.pass.cpp | ||
---|---|---|
110–122 | I when with CharT to be consistent with the rest of the file (which I should have done in the first place, instead of using charT to be consistent with the working draft). |
Comment Actions
Thanks for the fix. LGTM!
libcxx/test/std/utilities/format/format.formatter/format.context/types.compile.pass.cpp | ||
---|---|---|
110–122 | I too prefer CharT since that's consistent with the other <format> tests. |
Primarily just to rename the lowercase template parameter charT.