This is an archive of the discontinued LLVM Phabricator instance.

Differential D117554

[SelDag] Fix incorrect assertion after 545624973628dfca.
AbandonedPublic

Authored by fhahn on Jan 18 2022, 3:43 AM.

Details

Reviewers
None
Summary

This is an attempt to fix the failing pre-commit tests.

Diff Detail

Event Timeline

fhahn created this revision.Jan 18 2022, 3:43 AM
Herald added a subscriber: hiraditya. · View Herald TranscriptJan 18 2022, 3:43 AM
fhahn requested review of this revision.Jan 18 2022, 3:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 18 2022, 3:43 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B143981: Diff 400794.Jan 18 2022, 4:29 AM
fhahn abandoned this revision.Jul 1 2022, 7:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 1 2022, 7:31 AM

Revision Contents

PathSize
llvm/
lib/
CodeGen/
SelectionDAG/
6 lines

Diff 400794

llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp

Show First 20 Lines • Show All 4,401 Lines • ▼ Show 20 LinesSDValue DAGTypeLegalizer::WidenVecRes_VP_LOAD(VPLoadSDNode *N) {
SDValue EVL = N->getVectorLength(); SDValue EVL = N->getVectorLength();
ISD::LoadExtType ExtType = N->getExtensionType(); ISD::LoadExtType ExtType = N->getExtensionType();
SDLoc dl(N); SDLoc dl(N);
// The mask should be widened as well // The mask should be widened as well
assert(getTypeAction(Mask.getValueType()) == assert(getTypeAction(Mask.getValueType()) ==
TargetLowering::TypeWidenVector && TargetLowering::TypeWidenVector &&
"Unable to widen binary VP op"); "Unable to widen binary VP op");
EVT WideMaskVT =
TLI.getTypeToTransformTo(*DAG.getContext(), Mask.getValueType());
(void)WideMaskVT;
Mask = GetWidenedVector(Mask); Mask = GetWidenedVector(Mask);
assert(Mask.getValueType().getVectorElementCount() == assert(Mask.getValueType().getVectorElementCount() ==
TLI.getTypeToTransformTo(*DAG.getContext(), Mask.getValueType()) WideMaskVT.getVectorElementCount() &&
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-         WideMaskVT.getVectorElementCount() &&
+             WideMaskVT.getVectorElementCount() &&
Lint: Pre-merge checks: clang-format: please reformat the code ``` - WideMaskVT.getVectorElementCount() && +…
.getVectorElementCount() &&
"Unable to widen vector load"); "Unable to widen vector load");
SDValue Res = SDValue Res =
DAG.getLoadVP(N->getAddressingMode(), ExtType, WidenVT, dl, N->getChain(), DAG.getLoadVP(N->getAddressingMode(), ExtType, WidenVT, dl, N->getChain(),
N->getBasePtr(), N->getOffset(), Mask, EVL, N->getBasePtr(), N->getOffset(), Mask, EVL,
N->getMemoryVT(), N->getMemOperand(), N->isExpandingLoad()); N->getMemoryVT(), N->getMemOperand(), N->isExpandingLoad());
// Legalize the chain result - switch anything that used the old chain to // Legalize the chain result - switch anything that used the old chain to
// use the new one. // use the new one.
▲ Show 20 Lines • Show All 1,696 Lines • Show Last 20 Lines