Page MenuHomePhabricator

[clang][dataflow] Add transfer functions for bind temporary and static cast
ClosedPublic

Authored by sgatev on Fri, Jan 14, 10:29 AM.

Details

Summary

This is part of the implementation of the dataflow analysis framework.
See "[RFC] A dataflow analysis framework for Clang AST" on cfe-dev.

Diff Detail

Event Timeline

sgatev created this revision.Fri, Jan 14, 10:29 AM
sgatev requested review of this revision.Fri, Jan 14, 10:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptFri, Jan 14, 10:29 AM
xazax.hun added inline comments.Fri, Jan 14, 11:42 AM
clang/lib/Analysis/FlowSensitive/Transfer.cpp
90–120

Wouldn't you dereference a null pointer for group decls?

sgatev marked an inline comment as done.Fri, Jan 14, 3:02 PM
sgatev added inline comments.
clang/lib/Analysis/FlowSensitive/Transfer.cpp
90–120

I couldn't figure what code to write that would create a group decl. Maybe because of https://github.com/llvm/llvm-project/blob/main/clang/lib/Analysis/CFG.cpp#L2842-L2856?

xazax.hun accepted this revision.Fri, Jan 14, 3:28 PM
xazax.hun added inline comments.
clang/lib/Analysis/FlowSensitive/Transfer.cpp
90–120

Oh, interesting! Let's add a comment about this.

This revision is now accepted and ready to land.Fri, Jan 14, 3:28 PM
sgatev updated this revision to Diff 400392.Sun, Jan 16, 9:40 AM
sgatev marked 2 inline comments as done.

Address reviewers' comments.

This revision was landed with ongoing or failed builds.Sun, Jan 16, 9:56 AM
This revision was automatically updated to reflect the committed changes.