This is an archive of the discontinued LLVM Phabricator instance.

Differential D117161

[libc] fix strtold_test formatting on ARM
ClosedPublic

Authored by michaelrj on Jan 12 2022, 2:34 PM.

Details

Reviewers
None
Commits
rG04e8c8f9973b: [libc] fix strtold_test formatting on ARM
Summary

I missed a variable when reformatting the tests. This fixes that.

Diff Detail

Event Timeline

michaelrj created this revision.Jan 12 2022, 2:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 12 2022, 2:34 PM
Herald added subscribers: libc-commits, ecnelises, tschuett, kristof.beyls. · View Herald Transcript
michaelrj requested review of this revision.Jan 12 2022, 2:34 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 12 2022, 2:35 PM
This revision was landed with ongoing or failed builds.
Closed by commit rG04e8c8f9973b: [libc] fix strtold_test formatting on ARM (authored by michaelrj). · Explain Why
This revision was automatically updated to reflect the committed changes.
michaelrj added a commit: rG04e8c8f9973b: [libc] fix strtold_test formatting on ARM.
Harbormaster completed remote builds in B143020: Diff 399475.Jan 12 2022, 2:39 PM

Revision Contents

PathSize
libc/
test/
src/
stdlib/
4 lines

Diff 399476

libc/test/src/stdlib/strtold_test.cpp

Show First 20 Lines • Show All 60 Lines • ▼ Show 20 Lines void run_test(const char *inputString, const ptrdiff_t expectedStrLen,
// +------+------+ // +------+------+
// | // |
// +-- 15 Exponent Bits // +-- 15 Exponent Bits
char *str_end = nullptr; char *str_end = nullptr;
#if defined(LONG_DOUBLE_IS_DOUBLE) #if defined(LONG_DOUBLE_IS_DOUBLE)
__llvm_libc::fputil::FPBits<long double> expected_fp = __llvm_libc::fputil::FPBits<long double> expected_fp =
__llvm_libc::fputil::FPBits<long double>(expectedRawData64); __llvm_libc::fputil::FPBits<long double>(expectedRawData64);
const int expectedErrno = expectedErrno64; const int expected_errno = expectedErrno64;
#elif defined(SPECIAL_X86_LONG_DOUBLE) #elif defined(SPECIAL_X86_LONG_DOUBLE)
__llvm_libc::fputil::FPBits<long double> expected_fp = __llvm_libc::fputil::FPBits<long double> expected_fp =
__llvm_libc::fputil::FPBits<long double>(expectedRawData80); __llvm_libc::fputil::FPBits<long double>(expectedRawData80);
const int expected_errno = expectedErrno80; const int expected_errno = expectedErrno80;
#else #else
__llvm_libc::fputil::FPBits<long double> expected_fp = __llvm_libc::fputil::FPBits<long double> expected_fp =
__llvm_libc::fputil::FPBits<long double>(expectedRawData128); __llvm_libc::fputil::FPBits<long double>(expectedRawData128);
const int expectedErrno = expectedErrno128; const int expected_errno = expectedErrno128;
#endif #endif
errno = 0; errno = 0;
long double result = __llvm_libc::strtold(inputString, &str_end); long double result = __llvm_libc::strtold(inputString, &str_end);
__llvm_libc::fputil::FPBits<long double> actual_fp = __llvm_libc::fputil::FPBits<long double> actual_fp =
__llvm_libc::fputil::FPBits<long double>(); __llvm_libc::fputil::FPBits<long double>();
actual_fp = __llvm_libc::fputil::FPBits<long double>(result); actual_fp = __llvm_libc::fputil::FPBits<long double>(result);
▲ Show 20 Lines • Show All 138 Lines • Show Last 20 Lines