This is an archive of the discontinued LLVM Phabricator instance.

Differential D117145

[CMake] Option -fno-shrink-wrap is incorrectly handled
Needs ReviewPublic

Authored by ljmf00 on Jan 12 2022, 1:32 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

CMake variables are case sensitive, and Uppercase_* variables doesn't exist.
This patch uses the correct variable.

Diff Detail

Unit TestsFailed

TimeTest
60,070 msx64 debian > AddressSanitizer-x86_64-linux.TestCases::scariness_score_test.cpp
60,410 msx64 debian > Clang.Driver::arm-cortex-cpus-2.c
60,190 msx64 debian > Clang.Driver::emit-reproducer.c
60,470 msx64 debian > Clang.Driver::fsanitize.c
60,530 msx64 debian > Clang.OpenMP::target_defaultmap_codegen_01.cpp
View Full Test Results (7 Failed)

Revision Contents

PathSize
llvm/
cmake/
modules/
2 lines

Diff 434565

llvm/cmake/modules/HandleLLVMOptions.cmake

Show First 20 Lines • Show All 331 Lines • ▼ Show 20 Lines else()
if ((CMAKE_COMPILER_IS_GNUCXX AND if ((CMAKE_COMPILER_IS_GNUCXX AND
NOT (LLVM_NATIVE_ARCH STREQUAL "SystemZ" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 10.3)) NOT (LLVM_NATIVE_ARCH STREQUAL "SystemZ" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 10.3))
OR (CMAKE_CXX_COMPILER_ID MATCHES "Clang" AND CMAKE_CXX_COMPILER_VERSION GREATER_EQUAL 14)) OR (CMAKE_CXX_COMPILER_ID MATCHES "Clang" AND CMAKE_CXX_COMPILER_VERSION GREATER_EQUAL 14))
add_flag_if_supported("-fno-semantic-interposition" FNO_SEMANTIC_INTERPOSITION) add_flag_if_supported("-fno-semantic-interposition" FNO_SEMANTIC_INTERPOSITION)
endif() endif()
endif() endif()
# GCC for MIPS can miscompile LLVM due to PR37701. # GCC for MIPS can miscompile LLVM due to PR37701.
if(CMAKE_COMPILER_IS_GNUCXX AND LLVM_NATIVE_ARCH STREQUAL "Mips" AND if(CMAKE_COMPILER_IS_GNUCXX AND LLVM_NATIVE_ARCH STREQUAL "Mips" AND
NOT Uppercase_CMAKE_BUILD_TYPE STREQUAL "DEBUG") NOT uppercase_CMAKE_BUILD_TYPE STREQUAL "DEBUG")
add_flag_or_print_warning("-fno-shrink-wrap" FNO_SHRINK_WRAP) add_flag_or_print_warning("-fno-shrink-wrap" FNO_SHRINK_WRAP)
endif() endif()
# gcc with -O3 -fPIC generates TLS sequences that violate the spec on # gcc with -O3 -fPIC generates TLS sequences that violate the spec on
# Solaris/sparcv9, causing executables created with the system linker # Solaris/sparcv9, causing executables created with the system linker
# to SEGV (GCC PR target/96607). # to SEGV (GCC PR target/96607).
# clang with -O3 -fPIC generates code that SEGVs. # clang with -O3 -fPIC generates code that SEGVs.
# Both can be worked around by compiling with -O instead. # Both can be worked around by compiling with -O instead.
if(${CMAKE_SYSTEM_NAME} STREQUAL "SunOS" AND LLVM_NATIVE_ARCH STREQUAL "Sparc") if(${CMAKE_SYSTEM_NAME} STREQUAL "SunOS" AND LLVM_NATIVE_ARCH STREQUAL "Sparc")
▲ Show 20 Lines • Show All 887 Lines • Show Last 20 Lines